Skip to content

lib: define kEnumerableProperty atomically#63609

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:kEnumerableProperty
Open

lib: define kEnumerableProperty atomically#63609
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:kEnumerableProperty

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented May 28, 2026

For readability sake

@aduh95
lib: define kEnumerableProperty atomically
3485220 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels May 28, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 28, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73804/

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (8d0a3b8) to head (3485220).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #63609   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files         730      730           
  Lines      234782   234783    +1     
  Branches    43953    43955    +2     
=======================================
+ Hits       211993   211995    +2     
- Misses      14501    14512   +11     
+ Partials     8288     8276   -12
Files with missing lines Coverage Δ
lib/internal/util.js 96.83% <100.00%> (+<0.01%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 28, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented May 28, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/73811/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@targos targos targos approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @panva @targos @legendecas