crypto: strengthen argument CHECKs in TurboSHAKE#62763
Open
tniessen wants to merge 1 commit intonodejs:mainfrom
Open
crypto: strengthen argument CHECKs in TurboSHAKE#62763tniessen wants to merge 1 commit intonodejs:mainfrom
tniessen wants to merge 1 commit intonodejs:mainfrom
Conversation
Instead of first discarding the top 24 bits of the argument and then checking that the low 8 bits are within the expected range, first check that the original 32-bit integer is within the expected range and then discard the top 24 bits.
Collaborator
|
Review requested:
|
panva
approved these changes
Apr 15, 2026
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62763 +/- ##
==========================================
- Coverage 91.55% 89.68% -1.87%
==========================================
Files 356 706 +350
Lines 149601 218127 +68526
Branches 23395 41734 +18339
==========================================
+ Hits 136967 195632 +58665
- Misses 12371 14406 +2035
- Partials 263 8089 +7826
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of first discarding the top 24 bits of the argument and then checking that the low 8 bits are within the expected range, first check that the original 32-bit integer is within the expected range and then discard the top 24 bits.