test: deflake watch mode worker test#63384
Open
trivikr wants to merge 1 commit into
Open
Conversation
Trigger watch restarts by appending whitespace instead of rewriting watched modules. This avoids transient empty or partial ESM dependency contents while the restarted worker is loading. Use a separate temporary directory for each subtest so concurrent subtests do not share worker and dependency file names. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63384 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.02%
==========================================
Files 714 714
Lines 225629 225629
Branches 42702 42674 -28
==========================================
- Hits 203211 203185 -26
+ Misses 14232 14222 -10
- Partials 8186 8222 +36 🚀 New features to boost your workflow:
|
lpinca
approved these changes
May 17, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an intermittent failure in
test-watch-mode-worker.mjs.The test previously triggered watch restarts by repeatedly rewriting the
watched file with
writeFileSync(). Since that truncates before writing, arestarted ESM worker could occasionally observe an empty or partially written
nested dependency and fail with a missing default export error.
This PR changes the restart trigger to append harmless whitespace instead, so
the watched module remains valid while still producing a file change event. It
also gives each subtest its own temporary directory to avoid shared
worker.*/dep.*/sub-dep.*paths when subtests run concurrently.Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Assisted-by: openai:gpt-5.5