Reland Windows test fixes with proper credit#63244
Merged
Merged
Conversation
richardlau
approved these changes
May 11, 2026
H4ad
approved these changes
May 11, 2026
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
StefanStojanovic
approved these changes
May 12, 2026
This reverts commit 130398a. PR-URL: nodejs#63244 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
There was an assumption that the `WeakRef` would be kept alive but it seems to not always be true on Windows. This commit makes sure it's kept alive. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#63244 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Signed-off-by: inoway46 <inoueyuya416@gmail.com> PR-URL: nodejs#63244 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
d181cdf to
1dc50f9
Compare
Contributor
Author
|
Landed in b06aee0...1dc50f9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#63209 should not have landed with commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.
, this PR reverts the commit that landed and re-land the commit with appropriate author and message.