test: deflake connection refused proxy tests#63395
Open
trivikr wants to merge 1 commit into
Open
Conversation
Use 127.0.0.1:10, matching existing refused-connection tests, instead of binding and releasing an ephemeral port that can be reused before the child process connects. Clear NO_PROXY and no_proxy so local proxy bypass settings do not skip the proxy connection attempt. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63395 +/- ##
==========================================
+ Coverage 90.05% 90.08% +0.03%
==========================================
Files 714 714
Lines 225704 225704
Branches 42714 42735 +21
==========================================
+ Hits 203250 203331 +81
+ Misses 14225 14165 -60
+ Partials 8229 8208 -21 🚀 New features to boost your workflow:
|
joyeecheung
approved these changes
May 18, 2026
Member
joyeecheung
left a comment
There was a problem hiding this comment.
I feel that there's still a risk that port 10 is used by some process, though that seems not super likely, in any case if that happens again I guess we can try probing a few more unlikely-to-be-used ports before using them for testing..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deflakes the HTTP and HTTPS connection-refused proxy tests.
The tests previously bound an ephemeral port, closed it, and then expected a
child process to get
ECONNREFUSEDwhen connecting to that released port. Thatleft a race where the port could be reused before the child process connected.
This updates the tests to use
127.0.0.1:10, matching existingrefused-connection tests, and clears
NO_PROXY/no_proxyso local proxybypass settings do not skip the proxy connection attempt.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-15.md#jstest-failure
Assisted-by: openai:gpt-5.5