Skip to content

test: shorten path in net pipe connect errors#63405

Open
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:test-net-pipe-connect-errors-relative-path
Open

test: shorten path in net pipe connect errors#63405
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:test-net-pipe-connect-errors-relative-path

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented May 18, 2026

Fixes a CI flake by using a short relative path for the non-socket file, avoiding Unix socket path length limits in long or multibyte workspaces.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.05%. Comparing base (debe2ed) to head (451e092).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #63405   +/-   ##
=======================================
  Coverage   90.05%   90.05%           
=======================================
  Files         714      714           
  Lines      225742   225742           
  Branches    42727    42720    -7     
=======================================
+ Hits       203285   203295   +10     
+ Misses      14234    14222   -12     
- Partials     8223     8225    +2     

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants