http2: emit session close before stream close#63414
Open
mcollina wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
PR-URL: nodejs#63414 Signed-off-by: Matteo Collina <hello@matteocollina.com>
94d6b49 to
0984bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63412
This changes the HTTP/2 session shutdown path so that when the transport has
already been closed, the client session
'close'event is queued before streamclose callbacks are scheduled.
That gives clients a race-free chance to invalidate cached
ClientHttp2Sessioninstances before stream'close'handlers try to reusethat session and synchronously hit
ERR_HTTP2_INVALID_SESSION.