fs: fix enumerability of Date properties on Stats objects#63328
Open
LiviaMedeiros wants to merge 1 commit into
Open
fs: fix enumerability of Date properties on Stats objects#63328LiviaMedeiros wants to merge 1 commit into
Date properties on Stats objects#63328LiviaMedeiros wants to merge 1 commit into
Conversation
Signed-off-by: LiviaMedeiros <livia@cirno.name>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63328 +/- ##
========================================
Coverage 90.05% 90.05%
========================================
Files 714 714
Lines 225247 225368 +121
Branches 42578 42600 +22
========================================
+ Hits 202842 202966 +124
- Misses 14181 14185 +4
+ Partials 8224 8217 -7
🚀 New features to boost your workflow:
|
Renegade334
approved these changes
May 15, 2026
addaleax
approved these changes
May 15, 2026
jasnell
approved these changes
May 15, 2026
Collaborator
lpinca
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This basically implements suggestions for Temporal version of these properties: #60789 (comment) (prefer
setOwnProperty()in setter which also makes accessed properties enumerable), #60789 (comment) (prefersetOwnProperty()in getter to avoid triggering setter)./cc @aduh95