Skip to content

lib: cleanup stateless diffiehellman key handling#62645

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:cleanup-dh-followup
Apr 12, 2026
Merged

lib: cleanup stateless diffiehellman key handling#62645
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:cleanup-dh-followup

Conversation

@panva

@panva panva commented Apr 9, 2026

Copy link
Copy Markdown
Member

semver-major PRs that contain breaking changes and should be released in the next major version. follow up to #62527

@panva
lib: cleanup stateless diffiehellman key handling
dde51f3 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 9, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Apr 9, 2026
@codecov

codecov Bot commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.81%. Comparing base (e6ef477) to head (dde51f3).
⚠️ Report is 31 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62645   +/-   ##
=======================================
  Coverage   89.81%   89.81%           
=======================================
  Files         697      697           
  Lines      215773   215736   -37     
  Branches    41279    41271    -8     
=======================================
- Hits       193786   193770   -16     
+ Misses      14093    14086    -7     
+ Partials     7894     7880   -14
Files with missing lines Coverage Δ
lib/internal/crypto/diffiehellman.js 97.72% <ø> (-0.20%) ⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@panva panva requested review from anonrig and jasnell April 10, 2026 08:22
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 10, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 11, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72641/

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2026
@nodejs-github-bot nodejs-github-bot merged commit dfe438d into nodejs:main Apr 12, 2026
84 checks passed
@nodejs-github-bot

nodejs-github-bot commented Apr 12, 2026

Copy link
Copy Markdown
Collaborator

Landed in dfe438d

@panva panva deleted the cleanup-dh-followup branch April 12, 2026 05:40
@panva panva mentioned this pull request May 5, 2026
Merged
panva added a commit to panva/node that referenced this pull request May 26, 2026
@panva
lib: cleanup stateless diffiehellman key handling
2623964 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62645
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced May 26, 2026
Open
Closed
panva added a commit to panva/node that referenced this pull request May 26, 2026
@panva
lib: cleanup stateless diffiehellman key handling
8b5e20d 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62645
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@panva panva added backport-open-v24.x Indicate that the PR has an open backport backport-open-v26.x Indicate that the PR has an open backport labels May 26, 2026
aduh95 pushed a commit that referenced this pull request May 31, 2026
@panva @aduh95
lib: cleanup stateless diffiehellman key handling
6bef10e 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #62645
Backport-PR-URL: #63584
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 mentioned this pull request May 31, 2026
Merged
panva added a commit to panva/node that referenced this pull request Jun 19, 2026
@panva
lib: cleanup stateless diffiehellman key handling
1455de4 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62645
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sxa pushed a commit that referenced this pull request Jun 22, 2026
@panva @sxa
lib: cleanup stateless diffiehellman key handling
eaa0fb9 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: #62645
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 added backported-to-v26.x PRs backported to the v26.x-staging branch. and removed backport-open-v26.x Indicate that the PR has an open backport labels Jun 22, 2026
@sxa sxa mentioned this pull request Jun 22, 2026
Open
sxa added a commit to sxa/node that referenced this pull request Jun 22, 2026
@sxa
2026-06-22, Version 24.18.0 'Krypton' (LTS)
505dbf5 
Notable changes:

* crypto: update root certificates to NSS 3.123.1 (Node.js GitHub Bot) nodejs#63527
* (SEMVER-MINOR) buffer: increase Buffer.poolSize default to 64 KiB (Matteo Collina) nodejs#63597
* (SEMVER-MINOR) crypto: align key argument names in docs and error messages (Filip Skokan) nodejs#62527
* (SEMVER-MINOR) crypto: accept key data in crypto.diffieHellman() and cleanup DH jobs (Filip Skokan) nodejs#62527
* (SEMVER-MINOR) crypto: unify asymmetric key import through KeyObjectHandle::Init (Filip Skokan) nodejs#62499
* (SEMVER-MINOR) crypto: add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) nodejs#62183
* (SEMVER-MINOR) http: add writeInformation to send arbitrary 1xx status codes (Tim Perry) nodejs#63155
* (SEMVER-MINOR) inspector: expose precise coverage start to JS runtime (sangwook) nodejs#63079
* (SEMVER-MINOR) lib: cleanup stateless diffiehellman key handling (Filip Skokan) nodejs#62645

PR-URL: nodejs#64062

Signed-off-by: Stewart X Addison <sxa@ibm.com>
sxa added a commit that referenced this pull request Jun 22, 2026
@sxa
2026-06-22, Version 24.18.0 'Krypton' (LTS)
3d0ff91 
    Notable changes:

    * crypto: update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527
    * (SEMVER-MINOR) buffer: increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597
    * (SEMVER-MINOR) crypto: align key argument names in docs and error messages (Filip Skokan) #62527
    * (SEMVER-MINOR) crypto: accept key data in crypto.diffieHellman() and cleanup DH jobs (Filip Skokan) #62527
    * (SEMVER-MINOR) crypto: unify asymmetric key import through KeyObjectHandle::Init (Filip Skokan) #62499
    * (SEMVER-MINOR) crypto: add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
    * (SEMVER-MINOR) http: add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155
    * (SEMVER-MINOR) inspector: expose precise coverage start to JS runtime (sangwook) #63079
    * (SEMVER-MINOR) lib: cleanup stateless diffiehellman key handling (Filip Skokan) #62645

    PR-URL: #64062

    Signed-off-by: Stewart X Addison <sxa@ibm.com>
sxa added a commit that referenced this pull request Jun 22, 2026
@sxa
2026-06-22, Version 24.18.0 'Krypton' (LTS)
229592c 
Notable changes:

* crypto: update root certificates to NSS 3.123.1 (Node.js GitHub Bot) #63527
* (SEMVER-MINOR) buffer: increase Buffer.poolSize default to 64 KiB (Matteo Collina) #63597
* (SEMVER-MINOR) crypto: align key argument names in docs and error messages (Filip Skokan) #62527
* (SEMVER-MINOR) crypto: accept key data in crypto.diffieHellman() and cleanup DH jobs (Filip Skokan) #62527
* (SEMVER-MINOR) crypto: unify asymmetric key import through KeyObjectHandle::Init (Filip Skokan) #62499
* (SEMVER-MINOR) crypto: add TurboSHAKE and KangarooTwelve Web Cryptography algorithms (Filip Skokan) #62183
* (SEMVER-MINOR) http: add writeInformation to send arbitrary 1xx status codes (Tim Perry) #63155
* (SEMVER-MINOR) inspector: expose precise coverage start to JS runtime (sangwook) #63079
* (SEMVER-MINOR) lib: cleanup stateless diffiehellman key handling (Filip Skokan) #62645

PR-URL: #64062
sxa pushed a commit to sxa/node that referenced this pull request Jun 22, 2026
@panva @sxa
lib: cleanup stateless diffiehellman key handling
c6798c9 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62645
Backport-PR-URL: nodejs#63563
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
sxa pushed a commit to sxa/node that referenced this pull request Jun 23, 2026
@panva @sxa
lib: cleanup stateless diffiehellman key handling
c05f382 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
PR-URL: nodejs#62645
Backport-PR-URL: nodejs#63563
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v24.x Indicate that the PR has an open backport backported-to-v26.x PRs backported to the v26.x-staging branch. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@panva @nodejs-github-bot @jasnell @anonrig @aduh95