Skip to content

test: ensure WPT report is in out/wpt#62637

Open
panva wants to merge 2 commits intonodejs:mainfrom
panva:wpt-ensure-report-path
Open

test: ensure WPT report is in out/wpt#62637
panva wants to merge 2 commits intonodejs:mainfrom
panva:wpt-ensure-report-path

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 8, 2026

The test/wpt/test-webstorage.js file use of tmpdir.refresh() trips up the WPTReport class' ability to save its report in the right location.

This fixes an error in the daily wpt fyi job: https://github.com/nodejs/node/actions/runs/24112027541/job/70348488715#step:12:10653

@panva panva added the test Issues and PRs related to the tests. label Apr 8, 2026
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 8, 2026
@panva
test: ensure WPT report is in out/wpt
98cdd4d 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva force-pushed the wpt-ensure-report-path branch from d32e882 to 98cdd4d Compare April 8, 2026 12:03
@panva
Copy link
Copy Markdown
Member Author

panva commented Apr 8, 2026

cc @nodejs/web-standards

@panva panva added the web-standards Issues and PRs related to Web APIs label Apr 8, 2026
@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 8, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.80%. Comparing base (ae1c0e4) to head (42990ac).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #62637   +/-   ##
=======================================
  Coverage   89.79%   89.80%           
=======================================
  Files         697      697           
  Lines      215773   215773           
  Branches    41297    41310   +13     
=======================================
+ Hits       193749   193770   +21     
+ Misses      14117    14101   -16     
+ Partials     7907     7902    -5

see 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95
aduh95 reviewed Apr 8, 2026
View reviewed changes
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72567/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments

@MattiasBuelens MattiasBuelens MattiasBuelens approved these changes

@lpinca lpinca lpinca approved these changes

@jazelly jazelly jazelly approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. web-standards Issues and PRs related to Web APIs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@panva @nodejs-github-bot @MattiasBuelens @lpinca @aduh95 @jazelly