test_runner: fix failing suite hooks when marked with todo

MoLow · aduh95 · commit 60c83f6199d1 · 2026-05-07T15:41:51.000+02:00
Signed-off-by: Moshe Atlow <moshe@atlow.co.il> PR-URL: #63097 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
diff --git a/lib/internal/test_runner/utils.js b/lib/internal/test_runner/utils.js
@@ -384,7 +384,7 @@ function countCompletedTest(test, harness = test.root.harness) {
   }
   if (test.reportedType === 'suite') {
     harness.counters.suites++;
-    if (!test.passed) {
+    if (!test.passed && !test.isTodo) {
       harness.success = false;
     }
     return;
diff --git a/test/fixtures/test-runner/todo-suite-failing-hook.mjs b/test/fixtures/test-runner/todo-suite-failing-hook.mjs
@@ -0,0 +1,10 @@
+import { before, describe, it } from 'node:test';
+
+describe('todo suite with failing before hook', { todo: 'evaluating' }, () => {
+  before(() => {
+    throw new Error('simulated cleanup failure');
+  });
+
+  it('child 1', () => {});
+  it('child 2', () => {});
+});
diff --git a/test/parallel/test-runner-todo-suite-hook-failure.js b/test/parallel/test-runner-todo-suite-hook-failure.js
@@ -0,0 +1,24 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixtures = require('../common/fixtures');
+
+// A `before` hook failure inside a suite marked `todo` must not fail the run.
+// The `todo` flag on a suite signals that its results are advisory, the same
+// way it does on individual tests. Before this fix, the suite branch of
+// `countCompletedTest` flipped `harness.success` for any non-passing suite
+// regardless of `isTodo`, so a hook failure exited with code 1 even though
+// no failing tests were reported.
+const child = spawnSync(process.execPath, [
+  '--test',
+  '--test-reporter=tap',
+  fixtures.path('test-runner', 'todo-suite-failing-hook.mjs'),
+]);
+
+const stdout = child.stdout.toString();
+assert.strictEqual(child.signal, null);
+assert.strictEqual(child.status, 0,
+                   `expected exit 0, got ${child.status}\nstdout:\n${stdout}\nstderr:\n${child.stderr}`);
+assert.match(stdout, /# fail 0/);
+assert.match(stdout, /# todo 2/);

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ function countCompletedTest(test, harness = test.root.harness) {`
`384`	`384`	`}`
`385`	`385`	`if (test.reportedType === 'suite') {`
`386`	`386`	`harness.counters.suites++;`
`387`		`- if (!test.passed) {`
	`387`	`+ if (!test.passed && !test.isTodo) {`
`388`	`388`	`harness.success = false;`
`389`	`389`	`}`
`390`	`390`	`return;`