stream: noop pause/resume on destroyed streams

ronag · aduh95 · commit 29b196694c78 · 2026-05-07T15:41:36.000+02:00
Signed-off-by: Robert Nagy <ronagy@icloud.com> PR-URL: #62557 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -1233,6 +1233,9 @@ function nReadingNextTick(self) {
 // If the user uses them, then switch into old mode.
 Readable.prototype.resume = function() {
   const state = this._readableState;
+  if ((state[kState] & kDestroyed) !== 0) {
+    return this;
+  }
   if ((state[kState] & kFlowing) === 0) {
     debug('resume');
     // We flow only if there is no one listening
@@ -1273,6 +1276,9 @@ function resume_(stream, state) {
 
 Readable.prototype.pause = function() {
   const state = this._readableState;
+  if ((state[kState] & kDestroyed) !== 0) {
+    return this;
+  }
   debug('call pause');
   if ((state[kState] & (kHasFlowing | kFlowing)) !== kHasFlowing) {
     debug('pause');
diff --git a/test/parallel/test-stream-destroy.js b/test/parallel/test-stream-destroy.js
@@ -118,3 +118,13 @@ const http = require('http');
     req.end('asd');
   }));
 }
+
+{
+  // resume() and pause() should be no-ops on destroyed streams.
+  const r = new Readable({ read() {} });
+  r.destroy();
+  r.on('resume', common.mustNotCall());
+  r.on('pause', common.mustNotCall());
+  r.resume();
+  r.pause();
+}
