Skip to content

src: coerce spawnSync args to string once#62633

Merged
nodejs-github-bot merged 5 commits intonodejs:mainfrom
aduh95:spawn-sync-args-tostring
Apr 14, 2026
Merged

src: coerce spawnSync args to string once#62633
nodejs-github-bot merged 5 commits intonodejs:mainfrom
aduh95:spawn-sync-args-tostring

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 8, 2026

This also fixes a TOCTOU race condition for objects with non-constant toString returned value.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run. labels Apr 8, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72557/

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.78%. Comparing base (ae1c0e4) to head (e3aa3a3).
⚠️ Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
src/spawn_sync.cc 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62633      +/-   ##
==========================================
- Coverage   89.79%   89.78%   -0.01%     
==========================================
  Files         697      697              
  Lines      215773   215771       -2     
  Branches    41297    41298       +1     
==========================================
- Hits       193749   193729      -20     
- Misses      14117    14132      +15     
- Partials     7907     7910       +3
Files with missing lines Coverage Δ
src/spawn_sync.cc 68.92% <90.00%> (+0.32%) ⬆️

... and 43 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 8, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72559/

@aduh95 aduh95 requested review from RafaelGSS and anonrig April 9, 2026 11:01
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2026
@nodejs-github-bot nodejs-github-bot merged commit 54d7d14 into nodejs:main Apr 14, 2026
67 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 14, 2026

Landed in 54d7d14

@aduh95 aduh95 deleted the spawn-sync-args-tostring branch April 14, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@anonrig anonrig Awaiting requested review from anonrig

+1 more reviewer

@efekrskl efekrskl efekrskl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95 @nodejs-github-bot @panva @efekrskl @RafaelGSS