Skip to content

src: clean up experimental flag variables#62759

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:clean-up-experimental-flag-vars
Open

src: clean up experimental flag variables#62759
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:clean-up-experimental-flag-vars

Conversation

@aduh95
Copy link
Copy Markdown
Contributor

@aduh95 aduh95 commented Apr 15, 2026

  • fetch is no longer disable by a CLI flag
  • node:sqlite requires SQLite, obviously

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 15, 2026
- `fetch` is no longer disable by a CLI flag
- `node:sqlite` requires SQLite, obviously

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 force-pushed the clean-up-experimental-flag-vars branch from 02275ec to d55d5fb Compare April 15, 2026 16:05
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (3f52482) to head (d55d5fb).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62759      +/-   ##
==========================================
- Coverage   91.55%   89.69%   -1.87%     
==========================================
  Files         356      706     +350     
  Lines      149601   218122   +68521     
  Branches    23395    41738   +18343     
==========================================
+ Hits       136967   195634   +58667     
- Misses      12371    14406    +2035     
- Partials      263     8082    +7819     
Files with missing lines Coverage Δ
src/api/environment.cc 79.25% <100.00%> (ø)
src/node_options.cc 76.61% <ø> (ø)
src/node_options.h 98.00% <100.00%> (ø)

... and 469 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants