lib: improve Web Cryptography key validation ordering#62749
Open
panva wants to merge 4 commits intonodejs:mainfrom
Open
lib: improve Web Cryptography key validation ordering#62749panva wants to merge 4 commits intonodejs:mainfrom
panva wants to merge 4 commits intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62749 +/- ##
==========================================
- Coverage 89.69% 89.69% -0.01%
==========================================
Files 706 706
Lines 218127 218146 +19
Branches 41734 41760 +26
==========================================
+ Hits 195651 195662 +11
- Misses 14400 14413 +13
+ Partials 8076 8071 -5
🚀 New features to boost your workflow:
|
aduh95
approved these changes
Apr 15, 2026
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes key validation to match the Web Cryptography specification step ordering.
wrapKey/unwrapKey: Move the wrapping key algorithm name and usage checks from the sharedcipherOrWrap()helper into each individual caller (encrypt,decrypt,wrapKey,unwrapKey). This ensureswrapKeyvalidates the wrapping key (steps 9–10 of https://w3c.github.io/webcrypto/#SubtleCrypto-method-wrapKey) before attemptingexportKey(step 12), producing the correctInvalidAccessErrorinstead of a confusingNotSupportedErrorfrom the export step.Split the previously combined algorithm + usage check across all operations (
encrypt,decrypt,wrapKey,unwrapKey,sign,verify) into two distinct checks with separate error messages:"Key algorithm mismatch"when the key's algorithm does not match the requested operation, and"Unable to use this key to <op>"when the key lacks the required usage. Previously, both conditions produced the same generic message.