Skip to content

Support for different angular builders#8248

Closed
bboysokol wants to merge 332 commits intofirebase:feat/do-not-block-to-use-other-buildersfrom
bboysokol:master
Closed

Support for different angular builders#8248
bboysokol wants to merge 332 commits intofirebase:feat/do-not-block-to-use-other-buildersfrom
bboysokol:master

Conversation

@bboysokol
Copy link
Copy Markdown
Contributor

Description

This is PR which is based on another PR(#7557).
This PR supports the custom Angular builders requested in the following issues:

Scenarios Tested

Deployed Angular applications which uses following builders:

  • custom webpack
  • ngx-env builder.

joehan and others added 30 commits October 4, 2024 10:31
* Update emulator UI to 1.14.0

* Update Changelog

* typo
* make logs default to .firebase/logs/

* add changelog

* change log file name
* Starting to move to cloudmonitoring metric

* Use the quota metric to check CSQL free trial eligibility.

* Catch 404s

* formats

* PR fixes
* Updated changelog to include dart generation

* Update CHANGELOG.md

---------

Co-authored-by: joehan <joehanley@google.com>
* fixing some lint warnings, replacing some chained promises with async/await
* change sdk configuration button name

* update text for sdk configuration button, changelog

* update case

* update text

---------

Co-authored-by: joehan <joehanley@google.com>
* remove prompt at the end of init dataconnect:sdk

* Dont override gql files when picking existing empty service

* Dont override gql files when picking existing empty service

* schema default

* tests

* Update src/init/features/dataconnect/index.ts

---------

Co-authored-by: joehan <joehanley@google.com>
* fix create rollouts

* fix create rollout flow

* update flow to match api proposal

* add unit tests for rollouts command
* Default to default

* Use "default" alias project when there are multiple listed

* no only
* Updated to Data connect emulator 1.5.0

* Typo
* Updated requireAuth to include getting the access token

* Updated setGlobalDefaultAccount to include expiry

* Applied linter

* Addressed comments

* Update CHANGELOG.md

* formats

---------

Co-authored-by: joehan <joehanley@google.com>
* always include the default template the data connect

* comments

* tests
* Centralize logs when not in a firebase directory

* PR fixes

* PR fixes
…ns flag (#7724)

* Fixed Flutter web apps that might require the --no-tree-shake-icons flag in order to build. 

Co-authored-by: Leonardo Ortiz <leo@monogram.io>
Co-authored-by: Harold Shen <hlshen@google.com>
annajowang and others added 25 commits February 7, 2025 22:32
* fix: support `default` and `reqHandler` exports in Angular

Updated the export structure to ensure both `default` and `reqHandler` exports function when using Angular.

* changelog

* bump supported angular version

* changelog for version bump

---------

Co-authored-by: Leonardo Ortiz <leo@monogram.io>
* Stripping out some node 22 deprecated bits

* Bump form-data to not use deprecated utils.isArray

* Use old ajv in tests so that eslint doesn't error out

* switch to real version of superstatic

* changelog

* Update workflow to use node 22
* Fix issue where tester.groups can be undefined

* Added changelog entry

* Format changelog entry

* Update src/commands/appdistribution-testers-list.ts

---------

Co-authored-by: joehan <joehanley@google.com>
* Add handling for REQUIRE_FORCE issues.

* Add unit tests.

* Fix + some formatting.

* Make formatting fit a little better inside VSCode terminal.

* Remove merge conflict markings.
* Bump FDC local toolkit to v1.8.0.

* Update changelog.
* First pass at auto generating sdk configs

* Fixed formatting issues

* Removed extra command

* Deleted unnecessary files

* Fixed more linting'

* Removed test assertion

* Fixed formatting

* Updated erros

* Misc

* Updated platforms list

* Undid last changes

* Addressed comments

* Fixed client test

* Driveby type fixing

* missed a spot

* Fixed test

* Fix issue where if a user passes in an empty 'out' parameter, the CLI crashes

* Added intelligent sensing where app should be

* Fixed formatting

* Fixed lint

* Fixed app dir

* Misc

* Wrote tests

* Reverted apps sdkconfig changes

* Fixed formatting

* Small changes

* Revert shrinkwrap changes

* Updated test:management script

* Fixed apps-sdkconfig boolean check

* Fixed more boolean

* Fixed formatting

* Added changelog

* Added new options

* Removed unused var

* Added experimental flag

* Moved apps:init behind a flag

* Added apps:init command

* Removed unnecessary experiments

* Addressed comments

---------

Co-authored-by: Joe Hanley <joehanley@google.com>
…s. (#8204)

* Format INTERACTIVE_ACK issues as table as well and add extra "type" column to table.

* Update warning and prompt wording to reflect insecure operations as well as connector evolution issues.

* Wording.

* Sort issues in table by category and some formatting fixes.
* Use correct import path for data connect emulator

* Actually fix it this time

* fix the thing i broke and format

* Update src/emulator/dataconnect/pgliteServer.ts

Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>

---------

Co-authored-by: Maneesh Tewani <maneesht@users.noreply.github.com>
* Don't surface connector evolution or insecure operation issues in VSCode.'

* Fix

* Filter by "INSECURE" substring rather than warningLevel.
…hen env vars for emulators are set (#8231)

* fix bug where apphosting emulator info is not complete when env vars for other emulators are set

* add proper fix and test

* fix

* remove async from non-async test func

* address comments
* Bump FDC local toolkit to v1.8.2.

* Update changelog.
* fix: #8168 - enforce webframeworks only when needed

In deployments where `--only hosting:boo` is used, enforce webframeworks
enablement only when the target actually uses webframeworks.

* remove console

* add changelog, add tests

* Add matchesHostingTarget to improve readability

---------

Co-authored-by: Chalo Salvador <chalo@monogram.io>
…8237)

* Added env var to magically import data connect service from console

* actually check location too

* formats

* Formats
* Improve robustness of function discovery for python

Anecdotally, python function discovery is flakey. We propose 2 change in
this PR:

1. For python discovery, add a small initial delay for python's admin
server to boot.

2. Add a request timeout to retry call to retrieve trigger information.
Previously, the default timeout would've been set to OS-level TCP
timeout, which in my laptop was between 20~30s.

* Add changelog.

* Remove per-req timeout to accomodate loading large/slow main.py.

* Update changelog.

* Revert timeout bump.
@google-cla
Copy link
Copy Markdown

google-cla bot commented Feb 23, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@bboysokol bboysokol changed the title Handling for different angular builders Support for different angular builders Feb 23, 2025
@leoortizz leoortizz changed the base branch from master to feat/do-not-block-to-use-other-builders February 24, 2025 14:42
@bboysokol bboysokol closed this by deleting the head repository Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.