Skip to content

Support node 22 - #8136

Merged
joehan merged 8 commits into
masterfrom
jh-node-22
Feb 10, 2025
Merged

joehan merged 8 commits into
masterfrom
jh-node-22

Conversation

@joehan

@joehan joehan commented Jan 23, 2025 •

Copy link
Copy Markdown
Member

Description

Fixes a bunch of places where our dependencies were using builtin methods that were deprecated in Node 22.

TODO before merge:

  • Switch to a real version of superstatic instead of pointing at a git branch
  • Add node 22 to CI

Scenarios Tested

Ran the tests, and ran through a bunch of common commands without getting deprecation notices.

Sample Commands

@joehan
joehan marked this pull request as ready for review February 7, 2025 18:01
@joehan
joehan requested a review from bkendall February 7, 2025 18:01
@joehan

joehan commented Feb 7, 2025

Copy link
Copy Markdown
Member Author

Started to move Ci to node 22, but doing it piecemeal:

  1. In this PR, added 22 for the 'cheap' tests to verify they work.
  2. Next, I'll make these required checks (and remove the redundant versions)
  3. In a follow up PR, i'll move the integration tests over, and confirm that they work. I'll force merge that and then update the branch protection rules with the new required checks.

Comment thread src/unzip.spec.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants