Skip to content

[FDC] Remove confusing prompts#7801

Merged
joehan merged 10 commits intomasterfrom
fz/prompts
Oct 7, 2024
Merged

[FDC] Remove confusing prompts#7801
joehan merged 10 commits intomasterfrom
fz/prompts

Conversation

@fredzqm
Copy link
Copy Markdown
Contributor

@fredzqm fredzqm commented Oct 7, 2024

Description

  1. Remove prompt at the end of init dataconnect:sdk
  2. If developer picked an existing empty service, don't ask them if they want to override local gql with templated files.

Scenarios Tested

Pick up empty service. Don't override any GQL.
Screenshot 2024-10-07 at 12 13 44 PM

Generate SDK. Don't prompt any more.
Screenshot 2024-10-07 at 12 14 21 PM

Sample Commands

@fredzqm fredzqm requested a review from joehan October 7, 2024 19:14
@fredzqm fredzqm changed the title Remove confusing prompts [FDC} Remove confusing prompts Oct 7, 2024
@fredzqm fredzqm changed the title [FDC} Remove confusing prompts [FDC] Remove confusing prompts Oct 7, 2024
Comment thread src/init/features/dataconnect/index.ts Outdated
@joehan joehan enabled auto-merge (squash) October 7, 2024 19:52
@joehan joehan merged commit 36ce505 into master Oct 7, 2024
@fredzqm fredzqm deleted the fz/prompts branch October 7, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants