Fix sidebar sometimes not picking up CSS changes when built#7705
Merged
rrousselGit merged 4 commits intomasterfrom Oct 13, 2024
Merged
Fix sidebar sometimes not picking up CSS changes when built#7705rrousselGit merged 4 commits intomasterfrom
rrousselGit merged 4 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## launch.fdc-pp #7705 +/- ##
================================================
Coverage ? 55.61%
================================================
Files ? 417
Lines ? 28474
Branches ? 5823
================================================
Hits ? 15835
Misses ? 12470
Partials ? 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
11e17e6 to
e10fe25
Compare
…nto fix-sidebar-css
hlshen
approved these changes
Oct 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I've had cases where the sidebar didn't apply SCSS.
Adding this fixes it.
Long term, we should disable SCSS tree shaking I think. It's bothering to have to do this.
Scenarios Tested
Sample Commands