Add handling for REQUIRE_FORCE issues.#8151
Merged
rosalyntan merged 11 commits intomasterfrom Feb 10, 2025
Merged
Conversation
REQUIRE_FORCE issues.
rosalyntan
commented
Jan 30, 2025
joehan
previously requested changes
Feb 4, 2025
Member
joehan
left a comment
There was a problem hiding this comment.
LGTM other than the cli-table3 issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8151 +/- ##
==========================================
+ Coverage 51.12% 51.14% +0.02%
==========================================
Files 423 423
Lines 29722 29729 +7
Branches 6083 6085 +2
==========================================
+ Hits 15196 15206 +10
+ Misses 13160 13157 -3
Partials 1366 1366 ☔ View full report in Codecov by Sentry. |
joehan
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add handling for the
REQUIRE_FORCEwarning level. Iffdc buildreturns an issue withREQUIRE_FORCE, the--forceflag is required in order to deploy that change. Also includes a minor fix for parsing theWorkaroundobject.Scenarios Tested
firebase deploy --forcewith an operation missing an@authdirectivefirebase deploywith an operation missing an@authdirectiveSample Commands
firebase deploy