firebase · bboysokol · Oct 4, 2024 · Oct 4, 2024 · Oct 7, 2024 · Oct 7, 2024
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -20,7 +20,16 @@ module.exports = {
     "require-atomic-updates": "off", // This rule is so noisy and isn't useful: https://github.com/eslint/eslint/issues/11899
     "require-jsdoc": "off", // This rule is deprecated and superseded by jsdoc/require-jsdoc.
     "valid-jsdoc": "off", // This is deprecated but included in recommended configs.
-
+    "brikke/no-undeclared-imports": [
+      "error",
+      {
+        excludedFilePatterns: ["**/scripts/**/*", `update-notifier-cjs.d.ts`],
+        excludedModules: [
+          /node:/,
+          "express-serve-static-core", // We rely on just the types, and the package breaks our build.
+        ],
+      },
+    ],
     "no-prototype-builtins": "warn", // TODO(bkendall): remove, allow to error.
     "no-useless-escape": "warn", // TODO(bkendall): remove, allow to error.
     "prefer-promise-reject-errors": "warn", // TODO(bkendall): remove, allow to error.
@@ -107,7 +116,7 @@ module.exports = {
     sourceType: "module",
     warnOnUnsupportedTypeScriptVersion: false,
   },
-  plugins: ["prettier", "@typescript-eslint", "jsdoc"],
+  plugins: ["prettier", "@typescript-eslint", "jsdoc", "brikke"],
   settings: {
     jsdoc: {
       tagNamePreference: {
@@ -122,6 +131,7 @@ module.exports = {
   // TODO(jamesdaniels): add this to overrides instead
   ignorePatterns: [
     "src/dynamicImport.js",
+    "src/emulator/dataconnect/pg-gateway",
     "scripts/webframeworks-deploy-tests/nextjs/**",
     "scripts/webframeworks-deploy-tests/angular/**",
     "scripts/frameworks-tests/vite-project/**",

diff --git a/.github/workflows/node-test.yml b/.github/workflows/node-test.yml
@@ -42,14 +42,13 @@ jobs:
         working-directory: firebase-vscode
 
   vscode_unit:
-    # Using windows to bypass an error thrown by VScode
-    # when run in an environment that does not have a screen.
-    runs-on: windows-latest
+    runs-on: macos-latest
     strategy:
       matrix:
         node-version:
           - "18"
           - "20"
+          - "22"
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
@@ -62,8 +61,68 @@ jobs:
       - run: npm ci
       - run: npm install
         working-directory: firebase-vscode
+      - run: npm run build
+        working-directory: firebase-vscode
       - run: npm run test:unit
         working-directory: firebase-vscode
+      - uses: codecov/codecov-action@v3
+        if: matrix.node-version == '20'
+
+  vscode_integration:
+    runs-on: macos-latest
+    strategy:
+      matrix:
+        node-version:
+          - "18"
+          - "20"
+
+    env:
+      FIREBASE_EMULATORS_PATH: ${{ github.workspace }}/emulator-cache
+      # This overrides the binary which runs firebase commands in the extension tasks such as emulator start.
+      # Currently, CI fails to start with npx so we change it to the global firebase binary.
+      FIREBASE_BINARY: firebase
+
+    steps:
+      - name: Setup Java JDK
+        uses: actions/setup-java@v3.3.0
+        with:
+          java-version: 17
+          distribution: temurin
+
+      - uses: actions/checkout@v4
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1.7.2
+        with:
+          install-dependencies: true
+          install-chromedriver: true
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: npm
+          cache-dependency-path: firebase-vscode/package-lock.json
+
+        # TODO temporary workaround for GitHub Actions CI issue:
+        # npm ERR! Your cache folder contains root-owned files, due to a bug in
+        # npm ERR! previous versions of npm which has since been addressed.
+      - run: sudo chown -R 501:20 "/Users/runner/.npm" || exit 1
+      - run: npm ci
+      - run: npm install
+        working-directory: firebase-vscode
+      - run: npm run build
+        working-directory: firebase-vscode
+
+      - run: npm i -g firebase-tools@latest
+
+      - uses: GabrielBB/xvfb-action@v1
+        with:
+          run: npm run test:e2e
+          working-directory: firebase-vscode
+
+      - uses: actions/upload-artifact@v4
+        if: failure()
+        with:
+          name: screenshots
+          path: firebase-vscode/src/test/screenshots
 
       - uses: codecov/codecov-action@v3
         if: matrix.node-version == '20'
@@ -75,6 +134,7 @@ jobs:
         node-version:
           - "18"
           - "20"
+          - "22"
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
@@ -93,7 +153,7 @@ jobs:
   integration:
     needs: unit
     if: contains(fromJSON('["push", "merge_group"]'), github.event_name)
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
 
     env:
       FIREBASE_EMULATORS_PATH: ${{ github.workspace }}/emulator-cache
@@ -123,13 +183,19 @@ jobs:
           - npm run test:triggers-end-to-end
           - npm run test:triggers-end-to-end:inspect
           - npm run test:dataconnect-deploy
+          - npm run test:dataconnect-emulator
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
           cache: npm
           cache-dependency-path: npm-shrinkwrap.json
+      - name: Setup Chrome
+        uses: browser-actions/setup-chrome@v1.7.2
+        with:
+          install-dependencies: true
+          install-chromedriver: true
       - name: Cache firebase emulators
         uses: actions/cache@v3
         with:
@@ -178,6 +244,7 @@ jobs:
           - npm run test:storage-deploy
           # - npm run test:storage-emulator-integration
           # - npm run test:dataconnect-deploy #  TODO (joehanley): Reenable this - it should be safe to run in parallel
+          # - npm run test:dataconnect-emulator # TODO (joehanley): Figure out why this is failing
           - npm run test:frameworks
     steps:
       - name: Setup Java JDK
@@ -207,7 +274,7 @@ jobs:
       - run: ${{ matrix.script }}
       - name: Print debug logs
         if: failure()
-        run: type *debug.log
+        run: dir "*.log" /s/b | type
 
   check-package-lock:
     runs-on: ubuntu-latest
@@ -216,6 +283,7 @@ jobs:
       matrix:
         node-version:
           - "20"
+          - "22"
 
     steps:
       - uses: actions/checkout@v4
@@ -235,6 +303,7 @@ jobs:
       matrix:
         node-version:
           - "20"
+          - "22"
 
     steps:
       - uses: actions/checkout@v4
@@ -254,6 +323,7 @@ jobs:
       matrix:
         node-version:
           - "20"
+          - "22"
 
     steps:
       - uses: actions/checkout@v4

diff --git a/.gitignore b/.gitignore
@@ -1,6 +1,10 @@
 src/test/emulators/extensions/firebase/storage-resize-images@0.1.18/functions/node_modules/*
 src/test/emulators/extensions/firebase/storage-resize-images@0.1.18/functions/package.json
 src/test/emulators/extensions/firebase/storage-resize-images@0.1.18/functions/package-lock.json
+scripts/functions-deploy-tests/**/package-lock.json
+scripts/functions-discover-tests/**/**/package-lock.json
+.dataconnect
+*-debug.log
 
 /.vscode
 node_modules

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,4 +1,3 @@
-- Re-add a dialog to let users know TLS is being provisioned in App Hosting (#7595)
-- Improve Firebase Data Connect postgres security by granting fine grained SQL privileges to the users the need it. (#7578)
-- Remove `dataconnect:sql:migrate` command hard dependency on 'roles/cloudsql.admin'. (#7578)
-- Add support for setting the encryption configuration of restored firestore databases (#7483)
+- Add initial delay when loading python functions (#8239)
+- Enforce webframeworks enablement only on webframeworks sites (#8168)
+- Support 3rd party builders for Angular (#6779) (#6602)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -217,7 +217,7 @@ provide, the `Command.help` method accepts a long-form string to display for the
 
 #### Load the command
 
-Next, go to `command/index.js`, then add a line to load the command, for
+Next, go to `commands/index.ts`, then add a line to load the command, for
 example:
 
 ```javascript

diff --git a/README.md b/README.md
@@ -117,15 +117,16 @@ Detailed doc is [here](https://firebase.google.com/docs/cli/auth).
 
 ### Extensions Commands
 
-| Command           | Description                                                                                 |
-| ----------------- | ------------------------------------------------------------------------------------------- |
-| **ext**           | Display information on how to use ext commands and extensions installed to your project.    |
-| **ext:configure** | Configure an existing extension instance.                                                   |
-| **ext:info**      | Display information about an extension by name (extensionName@x.y.z for a specific version) |
-| **ext:install**   | Install an extension.                                                                       |
-| **ext:list**      | List all the extensions that are installed in your Firebase project.                        |
-| **ext:uninstall** | Uninstall an extension that is installed in your Firebase project by Instance ID.           |
-| **ext:update**    | Update an existing extension instance to the latest version.                                |
+| Command             | Description                                                                                 |
+| ------------------- | ------------------------------------------------------------------------------------------- |
+| **ext**             | Display information on how to use ext commands and extensions installed to your project.    |
+| **ext:configure**   | Configure an existing extension instance.                                                   |
+| **ext:info**        | Display information about an extension by name (extensionName@x.y.z for a specific version) |
+| **ext:install**     | Install an extension.                                                                       |
+| **ext:sdk:install** | Install and SDK for an extension so you can define the extension in a functions codebase.   |
+| **ext:list**        | List all the extensions that are installed in your Firebase project.                        |
+| **ext:uninstall**   | Uninstall an extension that is installed in your Firebase project by Instance ID.           |
+| **ext:update**      | Update an existing extension instance to the latest version.                                |
 
 ### Cloud Firestore Commands
 

diff --git a/firebase-vscode/CHANGELOG.md b/firebase-vscode/CHANGELOG.md
@@ -1,5 +1,103 @@
 ## NEXT
 
+## 0.13.0
+
+- Updated internal `firebase-tools` dependency to 13.30.0
+- [Added] Added `extraEnv` setting to help extension development.
+- [Added] Make Run Local button always present
+
+## 0.12.2
+
+- Updated internal `firebase-tools` dependency to 13.29.3
+- [Fixed] Fixed a bug where results panel would break on API error
+
+## 0.12.1
+
+- Updated internal `firebase-tools` dependency to 13.29.2
+- [Added] Added support for emulator import/export.
+- [Added] Added `debug` setting to run commands with `--debug`
+- [Fixed] Fixed a bug where emulator issues weren't being surfaced
+
+## 0.12.0
+
+- Updated internal firebase-tools dependency to 13.29.1
+- [Fixed] Fixed firebase binary detection for analytics
+
+## 0.11.1
+
+- [Fixed] Fixed IDX analytics issue
+
+## 0.11.0
+
+- Updated internal firebase-tools dependency to 13.28.0
+- [Fixed] Fixed an issue where generating an ad-hoc file would break codelenses
+
+## 0.10.8
+
+- Updated internal firebase-tools dependency to 13.25.0
+- [Fixed] Fixed an issue where the toolkit wouldn't start with misconfigured configs
+- [Fixed] Fixed a visual bug when selecting a Firebase project in an empty folder
+
+## 0.10.7
+
+- Updated internal firebase-tools dependency to 13.24.2
+- [Fixed] Fixed an issue where Add data and Read data would generate operations in the wrong folder
+- [Fixed] Fixed an issue where firebase version check produced false positives on Windows (#7910)
+
+## 0.10.6
+
+- Updated internal firebase-tools dependency to 13.23.1
+- [Added] Persist FIREBASE_BINARY env variable to settings.
+- [Fixed] Fixed an issue where .firebaserc was being overwritten by the extension (#7861)
+
+## 0.10.5
+
+- [Fixed] Fixed an issue where multiple instances of the extension would break the toolkit.
+
+## 0.10.4
+
+- [Fixed] Fixed an issue where log files would be written to non-Firebase directories.
+
+## 0.10.3
+
+- Updated internal firebase-tools dependency to 13.21.0
+- Updated default debug-log output to .firebase/logs directory
+- [Fixed] Fixed an issue where emulator startup would hang
+- Updated text for SDK configuration button
+
+## 0.10.2
+
+- Updated internal firebase-tools dependency to 13.20.2
+
+## 0.10.1
+
+- [Fixed] Fixed an issue where commands would be executed against directory default project instead of the currently selected project.
+- [Fixed] Fixed an issue where expired auth tokens would be used.
+- [Fixed] Fixed an issue where Add Data wouldn't generate UUID types
+- Updated README with feature descriptions
+
+## 0.10.0
+
+- [Added] UI overhaul.
+- [Added] Added View Docs button to see generated documentation for your schema and connectors.
+- [Fixed] Improved detection for emulator start up and shut down.
+- [Fixed] Improved error handling for variables pane.
+- [Added] Added Firebase path setting, to control which Firebase dbinary is used when executing commands.
+
+## 0.9.1
+
+- Updated internal firebase-tools dependency to 13.19.0
+
+## 0.9.0
+
+- Updated internal firebase-tools dependency to 13.18.0
+
+## 0.8.0
+
+- Updated internal firebase-tools dependency to 13.17.0
+
+- [Fixed] Extension properly picks up firebase.json changes during Firebase Init flow
+
 ## 0.7.0
 
 - Updated internal firebase-tools dependency to 13.16.0