Skip to content

Update text for SDK Configuration button#7798

Merged
joehan merged 7 commits intomasterfrom
hlshen/configure
Oct 7, 2024
Merged

Update text for SDK Configuration button#7798
joehan merged 7 commits intomasterfrom
hlshen/configure

Conversation

@hlshen
Copy link
Copy Markdown
Contributor

@hlshen hlshen commented Oct 7, 2024

Screenshot 2024-10-07 at 1 38 47 PM

@hlshen hlshen requested review from joehan and yuchenshi October 7, 2024 17:03
@hlshen hlshen marked this pull request as ready for review October 7, 2024 17:04
@fredzqm
Copy link
Copy Markdown
Contributor

fredzqm commented Oct 7, 2024

What do folks think of "Add SDK to app"?

Developer may not know what the configuration consists of, but they know they want to use it in their app.

(And thank you. I was thinking about creating a PR for this as well)

@joehan
Copy link
Copy Markdown
Member

joehan commented Oct 7, 2024

What do folks think of "Add SDK to app"?

Developer may not know what the configuration consists of, but they know they want to use it in their app.

(And thank you. I was thinking about creating a PR for this as well)

+1 to add SDK to app, seems like the clearest option.

Copy link
Copy Markdown
Member

@yuchenshi yuchenshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with whatever wording

@hlshen hlshen enabled auto-merge (squash) October 7, 2024 18:10
@fredzqm
Copy link
Copy Markdown
Contributor

fredzqm commented Oct 7, 2024

@fredzqm fredzqm disabled auto-merge October 7, 2024 18:18
@hlshen
Copy link
Copy Markdown
Contributor Author

hlshen commented Oct 7, 2024

I'm a bit indecisive. I feel that once you're in the yaml file, it makes sense to think of configuring settings. Thus "Configure Generated SDK" makes more sense.

@joehan joehan merged commit cbc44c0 into master Oct 7, 2024
@joehan joehan deleted the hlshen/configure branch October 7, 2024 20:09
@fredzqm
Copy link
Copy Markdown
Contributor

fredzqm commented Oct 8, 2024

I'm a bit indecisive. I feel that once you're in the yaml file, it makes sense to think of configuring settings. Thus "Configure Generated SDK" makes more sense.

"Configure Generated SDK" makes sense to us, but not really for developers.

On the connector.yaml, maybe "Use Connector in app".

Can come later. I think js and kotlin would work fine, but iOS needs additional steps.
CLI displays those messages. VS Code should do the same or we actually figure out how to import it in the app properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants