Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Master next#3518

Merged
jasonLaster merged 20 commits into
firefox-devtools:masterfrom
jasonLaster:master-next
Aug 1, 2017
Merged

Master next#3518
jasonLaster merged 20 commits into
firefox-devtools:masterfrom
jasonLaster:master-next

Conversation

@jasonLaster
Copy link
Copy Markdown
Contributor

@jasonLaster jasonLaster commented Aug 1, 2017 •
edited
Loading

Associated Issue: #3517
hub.io/debugger.html/CONTRIBUTING.html#pull-requests

Summary of Changes

i went through the commits on next and cherry picked them onto master. Most were already on master, some applied, some needed some tweaking.

https://github.com/devtools-html/debugger.html/tree/next

jasonLaster and others added 15 commits August 1, 2017 09:45
@jasonLaster
Bump dependencies (firefox-devtools#3287)
0a6331d 
* Bump dependencies

* move deps to dev-deps
@jasonLaster
touch up preview styles (firefox-devtools#3376)
ca45eb0
@yurydelendik @jasonLaster
WebAssembly text generation on debugger side (firefox-devtools#3238)
48d4f95
@jasonLaster
Fix source tree jumpiness (firefox-devtools#3382)
f4e938b
@bomsy @jasonLaster
[WIP] Search redux (firefox-devtools#3370)
15b7f93
@bomsy @jasonLaster
Search redux on textload (firefox-devtools#3435)
b4b95cf
@yurydelendik @jasonLaster
Do not set source.isWasm attribute for old Firefox. (firefox-devtools…
b062aaa 
…#3412)
@wldcordeiro @jasonLaster
Animate the SymbolModal's entrance/exit (firefox-devtools#3415)
b2bcd18 
* Animate symbol modal using react-transition-group

* Use z-index rather than pointer-events to move the .modal-wrapper

* fixup yarn

* Remove react-transition-group and just do the animation via the enabled prop and CSS

* Adjust animation to use Photon recommendations.

* drop duplicate close handler

* make flow happy
@bomsy @jasonLaster
flashing the line that the text was foun on (firefox-devtools#3492)
2dbe176
@bomsy @jasonLaster
Keyboard access (firefox-devtools#3502)
f0dbe76
@irfanhudda @jasonLaster
Remove line-height for function-signature (firefox-devtools#3504)
9f7fce0
@codehag @jasonLaster
SourceSearch Improve not-found UI (firefox-devtools#3473)
31c9011
@jasonLaster
dark theme tweaks
f1e75a6 
Dark theme tweaks
@jasonLaster
Fix race condition with project text search tests (firefox-devtools#3511
7ae74af 
)

* Fix race condition with project text search tests

* touchups

* make tab tests more asyncy
@greenkeeper @jasonLaster
fix(package): update devtools-source-map to version 0.9.0 (firefox-de…
cc07e74 
…vtools#3491)
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #3518 into master will increase coverage by 0.23%.
The diff coverage is 43.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
+ Coverage   51.72%   51.95%   +0.23%     
==========================================
  Files         106      110       +4     
  Lines        4377     4525     +148     
  Branches      911      935      +24     
==========================================
+ Hits         2264     2351      +87     
- Misses       2113     2174      +61
Impacted Files Coverage Δ
src/utils/makeRecord.js 100% <ø> (ø) ⬆️
src/selectors.js 100% <ø> (ø) ⬆️
src/components/Editor/CallSites.js 2.08% <0%> (-0.05%) ⬇️
src/components/Editor/Breakpoint.js 5.76% <0%> (-0.24%) ⬇️
src/utils/editor/index.js 10% <0%> (-4.64%) ⬇️
src/components/shared/SearchInput.js 8.33% <0%> (-0.37%) ⬇️
src/utils/breakpoint/index.js 78.46% <0%> (ø) ⬆️
src/actions/navigation.js 11.76% <0%> (-0.74%) ⬇️
src/utils/editor/source-documents.js 6.25% <0%> (-6.8%) ⬇️
src/components/Editor/Preview.js 4.83% <0%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab605e...5bca3e8. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 1, 2017 •
edited
Loading

Codecov Report

Merging #3518 into master will increase coverage by 0.25%.
The diff coverage is 46.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
+ Coverage   51.72%   51.97%   +0.25%     
==========================================
  Files         106      110       +4     
  Lines        4377     4529     +152     
  Branches      911      936      +25     
==========================================
+ Hits         2264     2354      +90     
- Misses       2113     2175      +62
Impacted Files Coverage Δ
src/selectors.js 100% <ø> (ø) ⬆️
src/utils/makeRecord.js 100% <ø> (ø) ⬆️
src/components/Editor/Breakpoint.js 5.76% <0%> (-0.24%) ⬇️
src/components/Editor/Preview.js 4.83% <0%> (ø) ⬆️
src/components/shared/SearchInput.js 8.33% <0%> (-0.37%) ⬇️
src/utils/editor/source-documents.js 6.25% <0%> (-6.8%) ⬇️
src/components/Editor/CallSites.js 2.08% <0%> (-0.05%) ⬇️
src/actions/navigation.js 11.76% <0%> (-0.74%) ⬇️
src/utils/breakpoint/index.js 78.46% <0%> (ø) ⬆️
src/utils/editor/index.js 10% <0%> (-4.64%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ab605e...d02b480. Read the comment docs.

@jasonLaster jasonLaster merged commit c119277 into firefox-devtools:master Aug 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasonLaster @yurydelendik @bomsy @wldcordeiro @irfanhudda @codehag