This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Adding types to the editor position/range objects.#3409
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3409 +/- ##
==========================================
- Coverage 50.05% 50.02% -0.04%
==========================================
Files 107 107
Lines 4457 4460 +3
Branches 920 920
==========================================
Hits 2231 2231
- Misses 2226 2229 +3
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Jul 21, 2017
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3403
Here's the Pull Request Doc
https://devtools-html.github.io/debugger.html/CONTRIBUTING.html#pull-requests
Summary of Changes
Test Plan
Tell us a little a bit about how you tested your patch.
STR is provided in #3403
Screenshots/Videos (OPTIONAL)