Bump dependencies#3287
Conversation
codehag
left a comment
There was a problem hiding this comment.
Looks good, found an eslint rule that we should add!
| }, | ||
| id: "node-menu-add-breakpoint", | ||
| label: L10N.getStr("editor.addBreakpoint") | ||
| }, |
There was a problem hiding this comment.
hmm this is old code, but it's hard to read. we are basically doing this here:
let breakpoint = { ... };
let conditional = { ... };
let disabled;
but because of how it is written, its easy to see this instead:
let breakpoint = {
id: ..
label: ..
conditional: ...
disabled
};
We should add an eslint rule that doens't allow for declarations to be done in a list, because there is little gain from this style, and it decreases comprehension. Adding this as a comment for myself so that we can do this later.
|
We have an issue with a license |
Codecov Report
@@ Coverage Diff @@
## master #3287 +/- ##
==========================================
+ Coverage 50.2% 50.25% +0.04%
==========================================
Files 106 106
Lines 4322 4320 -2
Branches 892 891 -1
==========================================
+ Hits 2170 2171 +1
+ Misses 2152 2149 -3
Continue to review full report at Codecov.
|
|
Is there any news about the licensing issue? |
* Bump dependencies * move deps to dev-deps
* Bump dependencies * move deps to dev-deps
* Bump dependencies * move deps to dev-deps
No description provided.