This repository was archived by the owner on Jan 11, 2023. It is now read-only.
[SourceSearch] Improve not-found UI#3473
Merged
jasonLaster merged 1 commit intoJul 31, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3473 +/- ##
==========================================
- Coverage 51.55% 51.54% -0.02%
==========================================
Files 110 110
Lines 4570 4571 +1
Branches 944 944
==========================================
Hits 2356 2356
- Misses 2214 2215 +1
Continue to review full report at Codecov.
|
jasonLaster
reviewed
Jul 27, 2017
| transform: translateY(-50%); | ||
| -webkit-transform: translateX(-50%); | ||
| -ms-transform: translateX(-50%); | ||
| transform: translateX(-50%); |
Contributor
There was a problem hiding this comment.
autoprefixer + vertical-center could help
|
|
||
| renderSvg() { | ||
| const { count, query } = this.props; | ||
| sadFaceStyles() { |
| SearchInput.defaultProps = { | ||
| size: "" | ||
| size: "", | ||
| noNegativity: false |
Contributor
There was a problem hiding this comment.
noNegativity: false this is too hard on the brain
9bc0278 to
6d50428
Compare
jasonLaster
reviewed
Jul 27, 2017
|
|
||
| # LOCALIZATION NOTE (sourceSearch.noResults): The center pane Source Search | ||
| # message when the query did not match any of the sources. | ||
| sourceSearch.noResults=No files matching %S found |
Contributor
There was a problem hiding this comment.
this should be changed to sourceSearch.noResults2
|
|
||
| renderSvg() { | ||
| const { count, query } = this.props; | ||
| hasErrorEmoji() { |
Contributor
There was a problem hiding this comment.
perhaps, shouldShowErrorEmoji
| SearchInput.defaultProps = { | ||
| size: "" | ||
| size: "", | ||
| showErrorEmoji: true |
Contributor
There was a problem hiding this comment.
can you update the storybook stories with this new field?
Contributor
|
Found two things:
|
Contributor
Author
|
or maybe i missed a comma... trying to check |
Contributor
Author
|
..sigh |
b1667b5 to
f31cd61
Compare
459cda5 to
870f99c
Compare
870f99c to
1859b84
Compare
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3469
Summary of changes
Before:
After:
Other places where search input is used still have the same styles:
