This repository was archived by the owner on Jan 11, 2023. It is now read-only.
WebAssembly text generation on debugger side#3238
Merged
Merged
Conversation
1a0fbaa to
c7fd37c
Compare
Codecov Report
@@ Coverage Diff @@
## next #3238 +/- ##
==========================================
- Coverage 50.41% 50.03% -0.39%
==========================================
Files 106 107 +1
Lines 4336 4457 +121
Branches 897 920 +23
==========================================
+ Hits 2186 2230 +44
- Misses 2150 2227 +77
Continue to review full report at Codecov.
|
c7fd37c to
4fb5921
Compare
jasonLaster
reviewed
Jul 13, 2017
| const { line, column } = getTokenLocation(editor.codeMirror, target); | ||
|
|
||
| this.toggleBreakpoint(line + 1, column - 2); | ||
| this.toggleBreakpoint( |
Contributor
There was a problem hiding this comment.
i suppose we can't use a similar toSourceLocation method here because of the strange column offset...
| key: index, | ||
| callSite, | ||
| editor, | ||
| sourceId, |
Contributor
There was a problem hiding this comment.
lets pass the selectedSource down if possible. I think that would be a little more useful
| let sourceLine = toSourceLine(selectedSource.get("id"), line); | ||
| const bp = breakpointAtLocation(breakpoints, selectedLocation, { | ||
| line: sourceLine | ||
| }); |
Contributor
There was a problem hiding this comment.
this is going to move after a rebase
| const sourceText = source.get("text"); | ||
| const sourceNumLines = typeof sourceText === "string" | ||
| ? sourceText.split("\n").length | ||
| : sourceText.get("binary").length; |
Contributor
There was a problem hiding this comment.
- can we look at
source.isWasmhere instead oftypeof sourceText === "string" - perhaps move this to a helper
utils/source
| updateLineNumberFormat(editor, sourceId); | ||
| } | ||
|
|
||
| function renderWasmText(editor, sourceId: string, wasm: any) { |
Contributor
There was a problem hiding this comment.
can we move much of this to utils/editor/wasm
function renderWasmText(editor, sourceId: string, wasm: any) {
const lines = getWasmLines(souceId, wasm)
let text = { split: () => lines, match: () => false };
editor.setText(text);
}| editor.setText(text); | ||
| } | ||
| updateLineNumberFormat(editor, sourceId); | ||
| editor.setMode(isSourceWasm ? { name: "text" } : getMode(source.toJS())); |
Contributor
There was a problem hiding this comment.
can we move isSourceWasm ? { name: "text" } to getMode?
4fb5921 to
c572053
Compare
jasonLaster
reviewed
Jul 14, 2017
jasonLaster
left a comment
Contributor
There was a problem hiding this comment.
couple of small comments, but otherwise looks good.
| if (prevProps.selectedLocation !== selectedLocation) { | ||
| if (selectedLocation && selectedLocation.line != undefined) { | ||
| this.pendingJumpLine = selectedLocation.line; | ||
| this.pendingJumpLine = selectedLocation; |
Contributor
There was a problem hiding this comment.
lets change pendingJumpLine to pendingJumpLocation
|
|
||
| if (gutter !== "CodeMirror-foldgutter") { | ||
| toggleBreakpoint(line + 1); | ||
| const sourceId = selectedSource ? selectedSource.get("id") : ""; |
Contributor
There was a problem hiding this comment.
Lets move the selectedSource higher up.
if (! selectedSource) {
return
}we can do the same thing in onToggleBreakpoint
7f78c27 to
412d1a7
Compare
…s#3387) * move editor to state to ensure that re-layouts are still ok * make flow happy / fix tests * remove editor state
…html/fix-shortcut Fix source search shortcut
* Adding VueJS logo Via https://github.com/vuejs/vuejs.org/blob/master/assets/logo.ai * Add support for VueJS frame collapsing
412d1a7 to
76487fd
Compare
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated Issue: n/a
Summary of Changes
Test Plan
Example test plan (for original source):
Alternative test plan (for wasm):
3a. Find/open "wasm:https://devtools-html.github.io/debugger-examples/examples/wasm/fib/fib.index.html:d65901927dbe8357"
4a. Set breakpoint at the beginnig of $func5 @0000027D
5a. Refresh refresh fib.index.html page
Expected results: stop at set breakpoint(s).
Some other defects found: