This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Search redux on textload#3435
Merged
jasonLaster merged 5 commits intoJul 25, 2017
Merged
Conversation
bomsy
commented
Jul 24, 2017
| return matches; | ||
| } | ||
|
|
||
| export default function searchSources(query, sources) { |
Contributor
Author
There was a problem hiding this comment.
moved to actions, test to be added
Codecov Report
@@ Coverage Diff @@
## next #3435 +/- ##
=======================================
+ Coverage 49.8% 50.5% +0.7%
=======================================
Files 109 109
Lines 4516 4520 +4
Branches 930 931 +1
=======================================
+ Hits 2249 2283 +34
+ Misses 2267 2237 -30
Continue to review full report at Codecov.
|
jasonLaster
approved these changes
Jul 25, 2017
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Jul 27, 2017
* wip search sources as the source text loads * search sources on textt load * fix flow issues * fix the tests * fix lint issues
jasonLaster
pushed a commit
to jasonLaster/debugger.html
that referenced
this pull request
Aug 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to searching using redux
Summary of Changes