Meta: Format TSX files with dprint#9439
Draft
fregante wants to merge 1 commit into
Draft
Conversation
Member
fregante
commented
May 11, 2026
- Follows Meta: Format TS files with dprint (once) #9240
- Follows Meta: Format JS/TS files with dprint #9437
fregante
commented
May 11, 2026
Member
Author
There was a problem hiding this comment.
Most of the noise comes from the imports sorting. The rest is mostly ok, but we still have that major/blocking whitespace issue.
If it cannot be fixed this week, I'll either do another format once merge (disabling eslint's import wrapping) or try to find a way limit dprint to import sorting or something.
| removeTextNodeContaining(assignYourself.previousSibling!, 'No one—'); | ||
| $('[aria-label="Select assignees"] summary').append( | ||
| <span style={{fontWeight: 'normal'}}> – {assignYourself}</span>, | ||
| <span style={{fontWeight: 'normal'}}>– {assignYourself}</span>, |
Member
Author
There was a problem hiding this comment.
Still broken. Did you have a patch @SunsetTechuila?
| <span className="IssueLabel hx_IssueLabel mr-2" rgh-conventional-commits={commit.rawType}> | ||
| {commit.type} | ||
| </span>, | ||
|
|
Member
Author
There was a problem hiding this comment.
🤷♂️ not a big deal though
|
|
||
| async function embedGist(link: HTMLAnchorElement): Promise<void> { | ||
| const info = <em> (loading)</em>; | ||
| const info = <em>(loading)</em>; |
| defaultBranchRef {name} | ||
| ${ | ||
| prs.map(pr => ` | ||
| prs.map(pr => ` |
Member
Author
There was a problem hiding this comment.
Still an issue, but not a big one
| > | ||
| <StateIcon className={stateColorMap[prInfo.state]} /> | ||
| <span> #{prInfo.number}</span> | ||
| <span>#{prInfo.number}</span> |
| {oldNames.length > 0 && ( | ||
| <div className="color-fg-muted mt-n3"> | ||
| <span className="text-small">previously named </span> | ||
| <span className="text-small">previously named</span> |
| </> | ||
| : meta?.css && !isCss | ||
| ? <> | ||
| •{' '} |
| <TagIcon className="v-align-middle" /> | ||
| {' '} | ||
| {aheadBy === undeterminableAheadBy || <sup className="ml-n2">+{aheadBy}</sup>} | ||
| <TagIcon className="v-align-middle" /> {aheadBy === undeterminableAheadBy || <sup className="ml-n2">+{aheadBy}</sup>} |
Member
Author
There was a problem hiding this comment.
Not terrible but it is less readable
| ); | ||
|
|
||
| return <div> {button} {tooltip} </div>; | ||
| return <div>{button} {tooltip}</div>; |
| attachElement(target, { | ||
| after: () => ( | ||
| <span className="color-fg-muted"> · Follows you</span> | ||
| <span className="color-fg-muted">· Follows you</span> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.