Conversation
fregante
commented
May 11, 2026
| const highlightedFeatureRegex | ||
| = /<p><a title="(?<highlightedId>[^"]+)"><\/a> (?<highlightedDescripion>.+)\n\t+<p><img src="(?<highlightedImage>.+?)">/g; | ||
| const highlightedFeatureRegex = | ||
| /<p><a title="(?<highlightedId>[^"]+)"><\/a> (?<highlightedDescripion>.+)\n\t+<p><img src="(?<highlightedImage>.+?)">/g; |
Member
Author
There was a problem hiding this comment.
I don't see an option to prevent this: https://dprint.dev/plugins/typescript/config/
operatorPosition is already set to nextLine but it doesn't affect =
Member
There was a problem hiding this comment.
It looks like adding support should be easy: dprint/dprint-plugin-typescript#414
Care to file an issue?
Member
Author
There was a problem hiding this comment.
See following comments, I'm ok with the current setup
| type Deinit = | ||
| | {disconnect: VoidFunction} | ||
| | {clear: VoidFunction} | ||
| | {destroy: VoidFunction} |
Member
Author
There was a problem hiding this comment.
Considering this formatting, I think = does look better on the first line
Member
Author
|
I don't see any controversial issues, other than a temporary "formatting .ts but not .tsx" Let's see how .tsx fares in a followup PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think now only .tsx is left