-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Meta: Format TSX files with dprint #9439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,7 +27,6 @@ function renderLabelInCommitTitle(commitTitleElement: HTMLElement): void { | |
| // Skip commits that are _only_ "ci:" without anything else. Rare but it would be confusing to show just the label | ||
| commit.raw === textNode.textContent | ||
| && !commitTitleElement.nextElementSibling | ||
|
|
||
| // Ensure that the element contains only plain text, not stuff like <code> | ||
| && commitTitleElement.childElementCount < 1 | ||
| ) { | ||
|
|
@@ -38,7 +37,6 @@ function renderLabelInCommitTitle(commitTitleElement: HTMLElement): void { | |
| <span className="IssueLabel hx_IssueLabel mr-2" rgh-conventional-commits={commit.rawType}> | ||
| {commit.type} | ||
| </span>, | ||
|
|
||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤷♂️ not a big deal though |
||
| // Keep scope outside because that's how they're rendered in release notes as well | ||
| commit.scope ? <span className="color-fg-muted">{commit.scope}</span> : '', | ||
| ); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,14 +16,14 @@ type GistData = { | |
|
|
||
| // Fetch via background.js due to CORB policies. Also memoize to avoid multiple requests. | ||
| const fetchGist = mem( | ||
| async (url: string): Promise<GistData> => | ||
| messageRuntime({fetchJson: `${url}.json`}), | ||
| async (url: string): Promise<GistData> => messageRuntime({fetchJson: `${url}.json`}), | ||
| ); | ||
|
|
||
| const isOnlyChild = (link: HTMLAnchorElement): boolean => link.textContent.trim() === link.parentElement!.textContent.trim(); | ||
| const isOnlyChild = (link: HTMLAnchorElement): boolean => | ||
| link.textContent.trim() === link.parentElement!.textContent.trim(); | ||
|
|
||
| async function embedGist(link: HTMLAnchorElement): Promise<void> { | ||
| const info = <em> (loading)</em>; | ||
| const info = <em>(loading)</em>; | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will revert |
||
| link.after(info); | ||
|
|
||
| try { | ||
|
|
@@ -39,7 +39,8 @@ async function embedGist(link: HTMLAnchorElement): Promise<void> { | |
| } else { | ||
| const container = <div />; | ||
| container.attachShadow({mode: 'open'}).append( | ||
| <style>{` | ||
| <style> | ||
| {` | ||
| .gist .gist-data { | ||
| max-height: 16em; | ||
| overflow-y: auto; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,13 +45,13 @@ function buildQuery(prsByRepo: Map<string, Pr[]>): string { | |
| nameWithOwner | ||
| defaultBranchRef {name} | ||
| ${ | ||
| prs.map(pr => ` | ||
| prs.map(pr => ` | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Still an issue, but not a big one |
||
| ${api.escapeKey('pr', pr.number)}: pullRequest(number: ${pr.number}) { | ||
| ref: baseRef {id} | ||
| refName: baseRefName | ||
| } | ||
| `).join('\n') | ||
| } | ||
| } | ||
| } | ||
| `; | ||
| }).join('\n'); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still broken. Did you have a patch @SunsetTechuila?