Meta: Format TS files with dprint (once) by fregante · Pull Request #9240 · refined-github/refined-github

fregante · 2026-04-22T10:00:19Z

Replaces and closes #9239

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/c3dc672a-de56-45b7-a27a-15d171bd96cb Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…arens wrapping Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/a0a5458b-72d6-472f-9517-ff55e16b62ef Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…estions Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/460890b1-23b1-4fe4-8f3e-7dd2e4208847 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…-files-with-dprint Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

… use helpers in selectors Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/2d1d5acc-7b73-4b87-8187-4c9afb857bcf Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…extContent Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/5376b822-64f3-4366-87d4-50eecc479cda Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/00571d53-38ab-475d-a61a-c1f07ff24f83 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

…s.tsx

fregante · 2026-04-22T10:15:41Z

YOLO

github-actions · 2026-04-22T10:15:50Z

To maintainers: Please add labels to this PR

fregante · 2026-04-22T10:19:54Z

So in this PR I went ahead and removed any changes I deemed downgrades, including and especially those touching the whitespace. Once dprint/dprint-plugin-typescript#476 is resolved, I assume dprint will roughly follow our existing style anyway.

SunsetTechuila · 2026-04-22T16:08:27Z

-	observe([
-		'main [href="/apps/github-actions"] ~ div a.status-actions', // Legacy
-		'[data-testid="check-run-item"] a[href*="/actions/runs/"]', // React component on isPRCommits
-	], addForPr, {signal});
+	observe(
+		[
+			'main [href="/apps/github-actions"] ~ div a.status-actions', // Legacy
+			'[data-testid="check-run-item"] a[href*="/actions/runs/"]', // React component on isPRCommits
+		],
+		addForPr,
+		{signal},
+	);


This is a downgrade

"arguments.preferHanging": "always" fixes this, but makes other calls look worse

SunsetTechuila · 2026-04-22T16:09:00Z

-	if (elementExists([
-		'button[data-hotkey="Mod+Enter"]:disabled',
-		'button[type="submit"]:disabled',
-	], form)) {
+	if (
+		elementExists([


This is a downgrade too

ifStatement.preferHanging doesn't have the onlySingleItem setting for some reason

SunsetTechuila · 2026-04-22T16:09:51Z

-			A submission via <kbd>enter</kbd> has been prevented. You can press <kbd>enter</kbd> again or use <kbd>{moduleKey}</kbd><kbd>enter</kbd>.
+			A submission via <kbd>enter</kbd> has been prevented. You can press <kbd>enter</kbd> again or use{' '}
+			<kbd>{moduleKey}</kbd>
+			<kbd>enter</kbd>.
 		</p>


Not configurable

dprint/dprint-plugin-typescript#500

The only relevant issue I can find. How can anyone like this?

Maybe it could be jsxTextNode.forceSingleLine like importDeclaration.forceSingleLine

I think generally formatters are somewhat aware of inline tags but they don't always handle them the best way. And honestly anything longer than 80 characters plus tags is going to be hard to follow anyway, so there's no winning. The only solution I can think of is to not break the line at all if whitespace or inline tags are involved. But even then there exceptions (we have a feature with " • " followed by a whole dropdown component)

SunsetTechuila · 2026-04-22T16:14:17Z

I don't understand the point of this PR. Just a lot of mostly unnecessary or even bad changes. Can we revert it?

SunsetTechuila · 2026-04-22T16:23:51Z

 		<span className="ml-2 diffstat tooltipped tooltipped-s" aria-label={tooltip}>
-			<span className="color-fg-success">+{additions}</span>{' '}
-			<span className="color-fg-danger">−{deletions}</span>{' '}
+			<span className="color-fg-success">+{additions}</span> <span className="color-fg-danger">−{deletions}</span>{' '}


fregante · 2026-04-22T16:38:22Z

I don't understand what you don't understand. You saw the dprint TS PR and suggested that the only issue we had (whitespace) was fixable and you had a patch do it already. I had even closed the PR but reopened because you seemed interested. If you didn't like any of this, then that was your time to say it. The changes here are exactly what dprint suggested, minus the whitespace ones.

fregante · 2026-04-23T07:57:57Z

Can we revert it?

We can if you prefer not using any formatter on TS files at all, not now not next month. Reverting to ESLint and its formatting rules.

The merge was fast-tracked because the PR touches 118 files and it contains a substantial amount of manual work and reviewing, so it couldn't risk getting conflicts.

SunsetTechuila · 2026-04-23T12:11:15Z

The merge was fast-tracked because the PR touches 118 files and it contains a substantial amount of manual work and reviewing, so it couldn't risk getting conflicts.

That's an explanation, thanks 👍

Regarding the formatting downgrades: I thought they could be fixed by tweaking the config, but it turns out they can't

SunsetTechuila · 2026-04-23T12:24:32Z

+			${
+				commits.map((commit: string) => `


Isn't affected by preferHanging at all

I give up on using issue search on GitHub

https://github.com/dprint/dprint-plugin-typescript/issues?q=is%3Aissue%20state%3Aopen%20%22%24%7B%22

https://github.com/dprint/dprint-plugin-typescript/issues?q=is%3Aissue%20state%3Aopen%20%24%7B

dprint/dprint-plugin-typescript#635

Can't complain about one GitHub bug without hitting another one! Fantastic

Copilot AI and others added 30 commits April 18, 2026 08:48

Initial setup: create dprint configuration for TS/TSX formatting

43ccbde

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/c3dc672a-de56-45b7-a27a-15d171bd96cb Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Format TS/TSX files with dprint and add lint:dprint script

0cd9b23

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/c3dc672a-de56-45b7-a27a-15d171bd96cb Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Add formatting commit to .git-blame-ignore-revs

6ae0011

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/c3dc672a-de56-45b7-a27a-15d171bd96cb Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Fix dprint config: no brace spaces, JSX double quotes, no multiline p…

eefc8c2

…arens wrapping Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/a0a5458b-72d6-472f-9517-ff55e16b62ef Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Fix JSX whitespace, template literal indentation, and apply code sugg…

54e4ab0

…estions Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/460890b1-23b1-4fe4-8f3e-7dd2e4208847 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/format-ts-tsx…

cc65370

…-files-with-dprint Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Merge remote-tracking branch 'origin/main' into copilot/format-ts-tsx…

638d157

…-files-with-dprint Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Discard changes to .git-blame-ignore-revs

45a61eb

Add is()/not() helpers, fix spaces, restore inline template literals,…

ffac632

… use helpers in selectors Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/2d1d5acc-7b73-4b87-8187-4c9afb857bcf Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Merge origin/main — prefer css-selectors.ts for is()/not() helpers

0c3bfe9

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Discard changes to package.json

2fe7093

Update feature-utils.ts

fd2703f

Fix dprint.json includes, missing JSX spaces, and embed-gist-inline t…

91b6d1b

…extContent Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/5376b822-64f3-4366-87d4-50eecc479cda Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Add @dprint/typescript dep, format all files, add Format CI job

de88d80

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/00571d53-38ab-475d-a61a-c1f07ff24f83 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Add permissions: contents: read to Format CI job

f0e2f66

Agent-Logs-Url: https://github.com/refined-github/refined-github/sessions/00571d53-38ab-475d-a61a-c1f07ff24f83 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Sometimes you just gotta do it yourself

cde594a

Fix CI

d67ed3a

Discard changes to source/features/improve-shortcut-help.tsx

3a0b0ab

Manual gears

f800934

Semi-automatic formatting :(

d3065fb

Fix eslint config

fb215a8

Restore eslint formatting

a84b2c3

Discard changes to source/features/clean-conversation-sidebar.tsx

b0f1525

Discard changes to source/features/conventional-commits.tsx

8fbf572

Discard changes to source/features/default-branch-button.tsx

292f77c

Discard changes to source/features/embed-gist-inline.tsx

beb4715

Discard changes to source/features/fit-textareas.tsx

ad2a1f1

Discard changes to source/features/list-prs-for-branch.tsx

8561c25

Discard changes to source/features/list-prs-for-file.tsx

7b5268f

Discard changes to source/features/new-repo-disable-projects-and-wiki…

f0f3edf

…s.tsx

fregante added 6 commits April 22, 2026 17:04

Discard changes to source/features/pr-first-commit-title.tsx

b2b82a9

Discard changes to source/features/repo-header-info.tsx

4742b78

Discard changes to source/features/rgh-feature-descriptions.tsx

b69252d

Discard changes to source/features/user-profile-follower-badge.tsx

d726b6f

Spaces

63de2bc

Restore eslint-config-prettier for svelte files anyway

966a562

fregante marked this pull request as ready for review April 22, 2026 10:13

fregante merged commit c0e15f4 into main Apr 22, 2026
14 checks passed

fregante deleted the dprint-but-eslint branch April 22, 2026 10:15

fregante added the meta Related to Refined GitHub itself label Apr 22, 2026

SunsetTechuila reviewed Apr 22, 2026

View reviewed changes

SunsetTechuila reviewed Apr 23, 2026

View reviewed changes

fregante mentioned this pull request Apr 24, 2026

Meta: Avoid failing silently for DOM searches #9246

Merged

This was referenced May 11, 2026

Meta: Format JS/TS files with dprint #9437

Merged

Meta: Format TSX files with dprint #9439

Draft

Uh oh!

Conversation

fregante commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

fregante commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

fregante commented Apr 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila commented Apr 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fregante commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fregante commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SunsetTechuila commented Apr 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SunsetTechuila Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

fregante commented Apr 22, 2026 •

edited

Loading

fregante commented Apr 22, 2026 •

edited

Loading

fregante commented Apr 23, 2026 •

edited

Loading

SunsetTechuila Apr 23, 2026 •

edited

Loading