-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Meta: Format TS files with dprint (once) #9240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
43ccbde
0cd9b23
6ae0011
eefc8c2
54e4ab0
cc65370
638d157
45a61eb
ffac632
0c3bfe9
2fe7093
fd2703f
91b6d1b
de88d80
f0e2f66
cde594a
d67ed3a
3a0b0ab
f800934
d3065fb
fb215a8
a84b2c3
b0f1525
8fbf572
292f77c
beb4715
ad2a1f1
8561c25
7b5268f
f0f3edf
b2b82a9
4742b78
b69252d
d726b6f
63de2bc
966a562
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,10 +22,12 @@ function onKeyDown(event: DelegateEvent<KeyboardEvent, HTMLInputElement>): void | |
| return; | ||
| } | ||
|
|
||
| if (elementExists([ | ||
| 'button[data-hotkey="Mod+Enter"]:disabled', | ||
| 'button[type="submit"]:disabled', | ||
| ], form)) { | ||
| if ( | ||
| elementExists([ | ||
|
Comment on lines
-25
to
+26
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a downgrade too
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| 'button[data-hotkey="Mod+Enter"]:disabled', | ||
| 'button[type="submit"]:disabled', | ||
| ], form) | ||
| ) { | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -37,7 +39,9 @@ function onKeyDown(event: DelegateEvent<KeyboardEvent, HTMLInputElement>): void | |
|
|
||
| const message = ( | ||
| <p className={'rgh-avoid-accidental-submissions ' + spacingClasses}> | ||
| A submission via <kbd>enter</kbd> has been prevented. You can press <kbd>enter</kbd> again or use <kbd>{moduleKey}</kbd><kbd>enter</kbd>. | ||
| A submission via <kbd>enter</kbd> has been prevented. You can press <kbd>enter</kbd> again or use{' '} | ||
| <kbd>{moduleKey}</kbd> | ||
| <kbd>enter</kbd>. | ||
| </p> | ||
|
Comment on lines
-40
to
45
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Very bad
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not configurable
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. dprint/dprint-plugin-typescript#500 The only relevant issue I can find. How can anyone like this?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe it could be
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think generally formatters are somewhat aware of inline tags but they don't always handle them the best way. And honestly anything longer than 80 characters plus tags is going to be hard to follow anyway, so there's no winning. The only solution I can think of is to not break the line at all if whitespace or inline tags are involved. But even then there exceptions (we have a feature with " • " followed by a whole dropdown component) |
||
| ); | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"arguments.preferHanging": "always"fixes this, but makes other calls look worse