Skip to content

Test-only PR with every event - #4030

Closed
fregante wants to merge 3 commits into
mainfrom
filter-test
Closed

Test-only PR with every event#4030
fregante wants to merge 3 commits into
mainfrom
filter-test

Conversation

@fregante

@fregante fregante commented Feb 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

For #4029

Please don't touch

@fregante

fregante commented Feb 27, 2021

Copy link
Copy Markdown
Member Author

Comment

@fregante

This comment has been minimized.

Sign in to view
fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore
@@ -1,3 +1,4 @@
// MUCH IGNORE

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment

This comment was marked as resolved.

Sign in to view

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment part of a whole review started later

fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore
fregante
fregante commented Feb 27, 2021
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

fregante
fregante commented Feb 27, 2021
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review with comment and this comment

Comment thread .gitignore
@@ -1,3 +1,4 @@
// MUCH IGNORE
node_modules
yarn.lock

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment part of a review

fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore
// MUCH IGNORE
node_modules
yarn.lock
distribution/build

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment part of a review without main comment

@fregante fregante self-assigned this Feb 27, 2021
@refined-github refined-github locked and limited conversation to collaborators Feb 27, 2021
@fregante
fregante marked this pull request as ready for review February 27, 2021 20:07
fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore Outdated
!test/web-ext-profile/.gitkeep
.cache
.parcel-cache
// VERY NOISE

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated comment

@fregante fregante closed this Feb 27, 2021
@fregante
fregante deleted the filter-test branch February 27, 2021 20:08
@fregante
fregante restored the filter-test branch February 27, 2021 20:08
@fregante fregante reopened this Feb 27, 2021
@fregante
fregante marked this pull request as draft February 27, 2021 20:09
@fregante
fregante changed the base branch from main to conversation-event-filter February 27, 2021 20:09
@fregante fregante changed the title Test-only PR Test-only PR with every event Feb 27, 2021
@fregante fregante modified the milestone: Demo milestone Feb 27, 2021
@fregante
fregante changed the base branch from conversation-event-filter to main February 27, 2021 20:11
@fregante fregante mentioned this pull request Feb 27, 2021
Merged
2 of 3 tasks
@fregante
fregante requested review from yakov116 and removed request for yakov116 February 27, 2021 20:12
@fregante fregante removed their assignment Feb 27, 2021
@fregante fregante reopened this Feb 27, 2021
@fregante fregante closed this Feb 27, 2021
@fregante fregante mentioned this pull request Feb 27, 2021
Closed
fregante
fregante commented Feb 27, 2021
View reviewed changes

@fregante fregante left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whole review, with comment in past, resolved review

Comment thread .gitignore
fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore
test/web-ext-profile
!test/web-ext-profile/.gitkeep
.cache
.parcel-cache

This comment was marked as resolved.

Sign in to view

fregante
fregante commented Feb 27, 2021
View reviewed changes
Comment thread .gitignore
yarn.lock
distribution/build
test/web-ext-profile
!test/web-ext-profile/.gitkeep

@fregante fregante Feb 27, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review with multiple threads (thread 1)

Comment thread .gitignore
@yakov116 yakov116 reopened this Feb 28, 2021
yakov116
yakov116 requested changes Feb 28, 2021
View reviewed changes

@yakov116 yakov116 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test request changes

yakov116
yakov116 approved these changes Feb 28, 2021
View reviewed changes

@yakov116 yakov116 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appove with comment

@yakov116 yakov116 closed this Feb 28, 2021
@fregante
fregante deleted the filter-test branch March 1, 2021 05:49
@fregante fregante mentioned this pull request Mar 1, 2021
Merged
@fregante fregante mentioned this pull request Jun 4, 2022
Open
@refined-github refined-github deleted a comment from fregante Jun 4, 2022
@fregante fregante linked an issue Jun 5, 2022 that may be closed by this pull request
Fixed sidebar doesn't work in long threads? #5681
Closed
2 of 4 tasks
@fregante fregante removed a link to an issue Jun 5, 2022
Fixed sidebar doesn't work in long threads? #5681
Closed
2 of 4 tasks
@fregante fregante mentioned this pull request Jul 8, 2022
Closed
@fregante fregante mentioned this pull request May 20, 2023
Closed
@refined-github refined-github unlocked this conversation May 20, 2023
fregante added a commit that referenced this pull request May 20, 2023
@fregante
PR #4030 mentioned from commit
b230ebf
@SunsetTechuila SunsetTechuila mentioned this pull request Feb 11, 2026
Merged
@forivall forivall mentioned this pull request Mar 15, 2026
Merged
Copilot AI mentioned this pull request May 7, 2026
Merged
This was referenced May 17, 2026
Closed
Merged
Copilot AI mentioned this pull request Jun 2, 2026
Merged
This was referenced Oct 13, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yakov116 yakov116 yakov116 approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fregante @yakov116