Skip to content

conversation-activity-filter - Also hide bot comments - #9361

Merged
fregante merged 13 commits into
mainfrom
copilot/conversation-activity-filter-hide-bots
May 7, 2026
Merged

fregante merged 13 commits into
mainfrom
copilot/conversation-activity-filter-hide-bots

Conversation

Copilot AI commented May 6, 2026 •

Copy link
Copy Markdown
Contributor

@fregante fregante changed the title [WIP] Add filter to hide bot comments in conversations conversation-activity-filter - Also hide bots May 7, 2026
Comment thread source/github-helpers/is-bot-comment.ts Outdated
Comment thread source/github-helpers/is-bot-comment.ts Outdated
Copilot AI changed the title conversation-activity-filter - Also hide bots conversation-activity-filter - Also hide bot comments May 7, 2026
Copilot AI requested a review from fregante May 7, 2026 14:43

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested and it will need a screenshot + description update, but the code looks good

Comment thread source/features/conversation-activity-filter.tsx Outdated
@fregante

fregante commented May 7, 2026

Copy link
Copy Markdown
Member

@copilot fix conflicts

Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>

Copilot AI commented May 7, 2026 •

Copy link
Copy Markdown
Contributor Author

Untested and it will need a screenshot + description update, but the code looks good

Addressed in 5220c2dc: conflicts are fixed, and the PR now includes updated description + screenshot.

UI screenshot

@copilot fix conflicts

Done in 5220c2dc: merged origin/main, resolved conflicts, and pushed the updated branch.

UI screenshot

Copilot AI requested a review from fregante May 7, 2026 15:01
@fregante

fregante commented May 7, 2026

Copy link
Copy Markdown
Member

Copilot always steals my screenshots 🤦‍♂️

@SunsetTechuila

Copy link
Copy Markdown
Contributor

It posted the same screenshot 5 times 🤣

@fregante
fregante marked this pull request as ready for review May 7, 2026 16:08
@SunsetTechuila

Copy link
Copy Markdown
Contributor

I think it would make sense to also hide comments for bots: #9361 (comment)

}

if (getCommentAuthor(item.firstElementChild!).endsWith('[bot]')) {
item.classList.add(botClassName);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processSimpleComment

Doesn't hide review replies: #9361 (comment)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok. Review threads where copilots comments are generally short and self-contained.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fregante fregante May 7, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fregante

fregante commented May 7, 2026

Copy link
Copy Markdown
Member

at-copilot: make changes to this PR blah blah

I think it would make sense to also hide comments for bots: #9361 (comment)

We can't reliably detect whether a comment is exclusively for bots, like this comment

@fregante fregante left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, merging

@fregante
fregante merged commit becab06 into main May 7, 2026
13 checks passed
@fregante
fregante deleted the copilot/conversation-activity-filter-hide-bots branch May 7, 2026 17:16
@fregante

fregante commented May 7, 2026

Copy link
Copy Markdown
Member

We can't reliably detect whether a comment is exclusively for bots

We could detect comments that have exclusively one paragraph that starts with <a href=copilot> but perhaps that would appear as buggy, because "some at-copilot comments are not hidden"

As the recent addition to the guidelines says: https://github.com/refined-github/refined-github/wiki/%22Can-you-add-this-feature%3F%22#dont-hide-user-content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

conversation-activity-filter - also hide bots

3 participants