Skip to content

conversation-activity-filter - Move to top right - #10187

Merged
fregante merged 6 commits into
refined-github:mainfrom
digvijay-555:move-activity-filter-to-actions
Oct 15, 2026
Merged

fregante merged 6 commits into
refined-github:mainfrom
digvijay-555:move-activity-filter-to-actions

Conversation

@digvijay-555

@digvijay-555 digvijay-555 commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10169

Description

Moves conversation-activity-filter from the metadata summary row (HeaderMetadata/ PullRequestHeaderSummary) into the title action area:

  • On Issues: mounts into [class="menuActionsContainer"] next to the border-less "Copy link" button (in desktop, mobile context area, and sticky header).
  • On PRs: mounts into [data-component="PageHeader"][data-has-nav]:is([data- component="PH_Actions"], [class="PageHeader-Actions"]).
  • Removes the 100ms delay since clean-conversation-headers does not manipulate the actions area.

Test URLs

Screenshot

1] PR View

ss1

2] Issue View

ss2

3] Mobile View

ss5

4] Sticky Layout View

ss6

5] Other Toggle Views

ss3 ss4

@github-actions github-actions Bot closed this Oct 13, 2026
@github-actions

This comment was marked as resolved.

@fregante

Copy link
Copy Markdown
Member

Thank you! The button should be on the left side of the existing buttons so that when adding it, we don't move the existing one.

Comment thread source/refined-github.ts Outdated
@fregante

Copy link
Copy Markdown
Member

when logged out

Refined GitHub does not support "logged out". Any code related to it should be removed from this PR

@digvijay-555
digvijay-555 force-pushed the move-activity-filter-to-actions branch from 85c03b8 to 24d8521 Compare October 13, 2026 11:13
@github-actions

Copy link
Copy Markdown

Please don't force-push to this PR, it makes it harder to see what changed since the last review.

We merge commits rather than squash, so we care more about reviewability than a clean history. Feel free to push dirty commits.

@digvijay-555
digvijay-555 requested a review from fregante October 13, 2026 11:15
@digvijay-555

Copy link
Copy Markdown
Contributor Author

Moved the button to the left side of the previous button
ss7

@digvijay-555

Copy link
Copy Markdown
Contributor Author

Hey @fregante I have reached the open PR limit since my previous PR (#10181) is not yet merged.

Comment thread source/features/conversation-activity-filter.tsx Outdated
Comment thread source/features/conversation-activity-filter.tsx Outdated
Comment thread source/features/conversation-activity-filter.tsx Outdated
@fregante fregante changed the title Move activity filter to actions conversation-activity-filter - Move to top right Oct 13, 2026
@fregante

fregante commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Two issues:

  • the tip text is inheriting the title styles: it probably just needs one extra class like text-body or whatever GitHub already uses to reset the font style/size to it
  • the button stays on non-Conversation tabs after visiting the Conversation: you can fix this by using the components/url.ts store inside the .svelte component and toggle the hidden attribute, e.g. <action-menu hidden={!pageDetect.isConversation(url)}>
Screenshot 10

@fregante

fregante commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Minor issue: the button still causes a shift of the "New issue" button on mobile, because the "New issue" button is now left-aligned. Same goes on the PRs and its buttons.

Desktop ✅

Screenshot 14 Screenshot 17

Mobile ⚠️

Screenshot 13 Screenshot 16

Solution

I'd only accept a solution to this if it's CSS-only. If not, good as-is for now.

Accepted places:

Screenshot 13 Screenshot 16

@fregante

fregante commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

I'm still seeing it on the wrong side

Screenshot

Comment thread source/features/conversation-activity-filter.svelte
@digvijay-555

Copy link
Copy Markdown
Contributor Author

Resolved the issue as below

1] Desktop view -

ss

2] Mobile view -

ss2

@fregante

Copy link
Copy Markdown
Member

Thank you for the screenshots! Can you also verify the PR one?

@digvijay-555

Copy link
Copy Markdown
Contributor Author

Yes its working correct there too

1] Desktop view -

image

2] Mobile view -

image

@fregante

Copy link
Copy Markdown
Member

One last check I forgot is the sticky header in PR. Just "it works" is enough and I'll merge

@digvijay-555

Copy link
Copy Markdown
Contributor Author

One last check I forgot is the sticky header in PR. Just "it works" is enough and I'll merge

Yes that works too

image

@fregante
fregante merged commit bd578dd into refined-github:main Oct 15, 2026
14 checks passed
@fregante

fregante commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Uhm, maybe you didn't push some commits? It's missing from me in the sticky header and it's on the left side of the buttons:

Screenshot 3 Screenshot 2

@digvijay-555

Copy link
Copy Markdown
Contributor Author

Uhm, maybe you didn't push some commits? It's missing from me in the sticky header and it's on the left side of the buttons:

Screenshot 3 Screenshot 2

Hi @fregante,

Thanks for catching that! I investigated the issues and resolved both:

  1. Sticky Header: In the PR sticky header, the long branch byline had nested flex containers defaulting to min-width: auto and branch names up to 35vw, which forced the container to horizontally overflow on narrow viewports and pushed the right-aligned <action-menu> off-screen / behind side panels. I've added proper flex shrinking/truncation so the byline truncates cleanly with ellipsis and the filter button stays visible at the right edge with standard margin.
  2. Button Ordering on Mobile: Observed [class*="menuActionsContainer"] across desktop, mobile context actions, and sticky headers, and applied CSS order rules to keep the primary buttons (New issue / Merge & Code) in their natural positions without shifting.

Since this PR was already merged, I've opened a follow-up PR with the fixes here: #10228 .

@fregante

fregante commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Can you explain where those screenshots came from? You said it works and posted the screenshots. Did you lie?

@digvijay-555

digvijay-555 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Can you explain where those screenshots came from? You said it works and posted the screenshots. Did you lie?

Why would I lie. Anyways the issue was of screen sizing. When viewed on complete desktop size screen for me it would show the sticky header. But while resizing the screen to reduce the width the button overflowed out of the window. This behavior was the reason you were unable to see the sticky header. Also same was the issue with the action button on the left side of the merge button in the pr view.

@digvijay-555

Copy link
Copy Markdown
Contributor Author

Can you explain where those screenshots came from? You said it works and posted the screenshots. Did you lie?

Why would I lie. Anyways the issue was of screen sizing. When viewed on complete desktop size screen for me it would show the sticky header. But while resizing the screen to reduce the width the button overflowed out of the window. This behavior was the reason you were unable to see the sticky header. Also same was the issue with the action button on the left side of the merge button in the pr view.

Recording.2026-10-15.235452.mp4

This might help you understand. Still facing the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

conversation-activity-filter should be moved to the title

2 participants