Repository navigation
conversation-activity-filter - Move to top right - #10187
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Thank you! The button should be on the left side of the existing buttons so that when adding it, we don't move the existing one. |
Refined GitHub does not support "logged out". Any code related to it should be removed from this PR |
85c03b8 to
24d8521
Compare
|
Please don't force-push to this PR, it makes it harder to see what changed since the last review. We merge commits rather than squash, so we care more about reviewability than a clean history. Feel free to push dirty commits. |
conversation-activity-filter - Move to top right
…d mobile placement
This reverts commit cceabc8.
…d mobile placement
|
Thank you for the screenshots! Can you also verify the PR one? |
|
One last check I forgot is the sticky header in PR. Just "it works" is enough and I'll merge |
Hi @fregante, Thanks for catching that! I investigated the issues and resolved both:
Since this PR was already merged, I've opened a follow-up PR with the fixes here: #10228 . |
|
Can you explain where those screenshots came from? You said it works and posted the screenshots. Did you lie? |
Why would I lie. Anyways the issue was of screen sizing. When viewed on complete desktop size screen for me it would show the sticky header. But while resizing the screen to reduce the width the button overflowed out of the window. This behavior was the reason you were unable to see the sticky header. Also same was the issue with the action button on the left side of the merge button in the pr view. |
Recording.2026-10-15.235452.mp4This might help you understand. Still facing the same issue. |


















Fixes #10169
Description
Moves
conversation-activity-filterfrom the metadata summary row (HeaderMetadata/PullRequestHeaderSummary) into the title action area:[class="menuActionsContainer"]next to the border-less "Copy link" button (in desktop, mobile context area, and sticky header).[data-component="PageHeader"][data-has-nav]:is([data- component="PH_Actions"], [class="PageHeader-Actions"]).clean-conversation-headersdoes not manipulate the actions area.Test URLs
conversation-activity-filtershould be moved to the title #10169Screenshot
1] PR View
2] Issue View
3] Mobile View
4] Sticky Layout View
5] Other Toggle Views