Repository navigation
conversation-activity-filter - Fix sticky header and mobile alignment - #10228
Open
digvijay-555 wants to merge 1 commit into
Open
digvijay-555 wants to merge 1 commit into
digvijay-555 wants to merge 1 commit into
Conversation
digvijay-555
force-pushed
the
fix-activity-filter-header-alignment
branch
from
October 15, 2026 18:03
5f90b9e to
70ef2d6
Compare
Member
|
This is WAY too much code. I just want a couple of extra rules, not a whole app worth of CSS. It just needs to change the order, keep it simple |
digvijay-555
force-pushed
the
fix-activity-filter-header-alignment
branch
from
October 15, 2026 18:29
70ef2d6 to
e022204
Compare
|
Please don't force-push to this PR, it makes it harder to see what changed since the last review. We merge commits rather than squash, so we care more about reviewability than a clean history. Feel free to push dirty commits. |
Contributor
Author
You're right, I over-complicated it trying to solve truncation edge cases on narrow widths. I've stripped all of that out and simplified it to just a couple of simple
|
digvijay-555
marked this pull request as ready for review
October 16, 2026 19:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10187
Description
Fixes edge cases discovered after #10187:
prTitleAreaand sticky header variants. Applied flex truncation (min-width: 0,max-width: 18vwfor branch names) to ensure long bylines do not push the<action-menu>off-screen or behind side panels on reduced viewport widths. 2. Mobile & Narrow Issue Layout: Targets[class*="menuActionsContainer"]so the button renders in mobile context actions as well as desktop, keeping the primary button (New issue) at the start ([New issue] [👁 ▾] [📋]).[Merge] [Code]buttons with the filter button on their right.Test URLs
conversation-activity-filtershould be moved to the title #10169Screenshots
Desktop Sticky header PR view
Action button on right side of buttons