Skip to content

Fix save on old editor#10665

Merged
rchiodo merged 1 commit into
masterfrom
rchiodo/fix_save
Mar 19, 2020
Merged

Fix save on old editor#10665
rchiodo merged 1 commit into
masterfrom
rchiodo/fix_save

Conversation

@rchiodo

@rchiodo rchiodo commented Mar 19, 2020

Copy link
Copy Markdown

For #10647

@rchiodo rchiodo self-assigned this Mar 19, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Comment thread news/2 Fixes/10647.md
@@ -0,0 +1 @@
Fix save button not working on notebooks. No newline at end of file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, so we actually did fully break save on insiders? For those customers I though they were just having issues with the VS Code save commands not working.

@rchiodo rchiodo merged commit e725dd8 into master Mar 19, 2020
@rchiodo rchiodo deleted the rchiodo/fix_save branch March 19, 2020 16:44
DonJayamanne added a commit that referenced this pull request Mar 20, 2020
* master:
  Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674)
  Disable blank issues (#10678)
  update mockito and minor test updates (#10671)
  Fix save on old editor (#10665)
  Job names were invalid (#10646)
  Telemetry updates (#10631)
  Remote session shutdownAll is killing all sessions (#10621)
DonJayamanne added a commit that referenced this pull request Mar 20, 2020
* master:
  Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674)
  Disable blank issues (#10678)
  update mockito and minor test updates (#10671)
  Fix save on old editor (#10665)
  Job names were invalid (#10646)
  Telemetry updates (#10631)
  Remote session shutdownAll is killing all sessions (#10621)
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants