Skip to content

Nightly flake job names were invalid#10646

Merged
rchiodo merged 1 commit into
masterfrom
rchiodo/fix_nightly
Mar 18, 2020
Merged

Nightly flake job names were invalid#10646
rchiodo merged 1 commit into
masterfrom
rchiodo/fix_nightly

Conversation

@rchiodo

@rchiodo rchiodo commented Mar 18, 2020

Copy link
Copy Markdown

No description provided.

@rchiodo rchiodo added the no-changelog No news entry required label Mar 18, 2020
@rchiodo rchiodo self-assigned this Mar 18, 2020
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #10646 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10646      +/-   ##
==========================================
- Coverage   60.63%   60.62%   -0.02%     
==========================================
  Files         583      583              
  Lines       31548    31551       +3     
  Branches     4487     4487              
==========================================
- Hits        19130    19127       -3     
- Misses      11446    11450       +4     
- Partials      972      974       +2     
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 95.19% <ø> (ø)
src/client/telemetry/index.ts 87.38% <ø> (ø)
src/client/datascience/constants.ts 99.71% <100.00%> (+<0.01%) ⬆️
src/client/datascience/gather/gather.ts 34.84% <100.00%> (+2.03%) ⬆️
src/datascience-ui/react-common/arePathsSame.ts 75.00% <0.00%> (-12.50%) ⬇️
src/client/common/utils/platform.ts 64.70% <0.00%> (-11.77%) ⬇️
src/client/linters/pydocstyle.ts 86.66% <0.00%> (-2.23%) ⬇️
src/client/datascience/debugLocationTracker.ts 76.56% <0.00%> (-1.57%) ⬇️
src/client/common/process/proc.ts 14.49% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f24ef7...84bc80e. Read the comment docs.

@rchiodo rchiodo merged commit 6438bee into master Mar 18, 2020
@rchiodo rchiodo deleted the rchiodo/fix_nightly branch March 18, 2020 20:25
DonJayamanne added a commit that referenced this pull request Mar 20, 2020
* master:
  Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674)
  Disable blank issues (#10678)
  update mockito and minor test updates (#10671)
  Fix save on old editor (#10665)
  Job names were invalid (#10646)
  Telemetry updates (#10631)
  Remote session shutdownAll is killing all sessions (#10621)
DonJayamanne added a commit that referenced this pull request Mar 20, 2020
* master:
  Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674)
  Disable blank issues (#10678)
  update mockito and minor test updates (#10671)
  Fix save on old editor (#10665)
  Job names were invalid (#10646)
  Telemetry updates (#10631)
  Remote session shutdownAll is killing all sessions (#10621)
@lock lock Bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants