Dev/greazer/telem updates#10631
Merged
Merged
Conversation
greazer
commented
Mar 17, 2020
Member
- Add some additional telemetry to track gather use.
- Updated the header at the top of gathered notebooks and script to point to a survey.
* Send telemetry when gather isn't available
Remove unneeded metadata
DonJayamanne
approved these changes
Mar 17, 2020
DavidKutu
approved these changes
Mar 17, 2020
rchiodo
reviewed
Mar 17, 2020
| await this.ipynbProvider.createNew(contents); | ||
| const editor = await this.ipynbProvider.createNew(contents); | ||
| this.gatheredNotebookList.push(editor); | ||
| editor.saved(this.onSavedGatheredNotebook.bind(this)); |
There was a problem hiding this comment.
You could do this another way.
editor.saved returns an idisposable. So you could eliminate the need for saving the editors in the list. Something like so:
let disposable : IDisposable;
const handler = () => {
sendTelemetryEvent(Telemetry.GatherSaved);
if (disposable) {
disposable.dispose();
}
}
disposable = editor.saved(handler);
Member
Author
There was a problem hiding this comment.
Ah, nice. I figured there had to be a prettier way
Codecov Report
@@ Coverage Diff @@
## master #10631 +/- ##
==========================================
- Coverage 60.79% 60.62% -0.18%
==========================================
Files 579 583 +4
Lines 31403 31551 +148
Branches 4469 4487 +18
==========================================
+ Hits 19091 19127 +36
- Misses 11342 11450 +108
- Partials 970 974 +4
Continue to review full report at Codecov.
|
IanMatthewHuff
approved these changes
Mar 18, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Member
Author
|
Made suggested change by Rich before submitting. |
DonJayamanne
added a commit
that referenced
this pull request
Mar 20, 2020
* master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)
DonJayamanne
added a commit
that referenced
this pull request
Mar 20, 2020
* master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.