Remote session shutdownAll is killing all sessions#10621
Merged
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
IanMatthewHuff
approved these changes
Mar 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #10621 +/- ##
==========================================
- Coverage 60.79% 60.61% -0.18%
==========================================
Files 579 583 +4
Lines 31412 31548 +136
Branches 4469 4487 +18
==========================================
+ Hits 19097 19124 +27
- Misses 11344 11450 +106
- Partials 971 974 +3
Continue to review full report at Codecov.
|
DonJayamanne
added a commit
that referenced
this pull request
Mar 20, 2020
* master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)
DonJayamanne
added a commit
that referenced
this pull request
Mar 20, 2020
* master: Turning new debugger experiment on for all users and reload experiment for 20% of users (#10674) Disable blank issues (#10678) update mockito and minor test updates (#10671) Fix save on old editor (#10665) Job names were invalid (#10646) Telemetry updates (#10631) Remote session shutdownAll is killing all sessions (#10621)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the live share tests are failing on the nightly flake. Root cause is the guestServer calling connectToServer and that function creating and destroying a session manager to retrieve kernel specs.
For guest mode, kernel specs aren't necessary.
For disposing a session manager, shutting down all kernels kills kernels that aren't created by the session manager too.