Add lint tests for topics#4
Conversation
| install: | ||
| - bundle install | ||
| notifications: | ||
| email: false |
There was a problem hiding this comment.
Rather than globally disabling this I think leaving it to the default for users to be able to receive email notifications bast on their own preferences would be better.
|
|
||
| ```bash | ||
| bundle install | ||
| rake |
There was a problem hiding this comment.
Actually: would be nice if this was script/cibuild like https://github.com/github/scripts-to-rule-them-all
| email: false | ||
| script: rake | ||
| cache: | ||
| bundler: true |
There was a problem hiding this comment.
Pedantry: I'd order this file sudo, cache, empty line, install, script, empty line, notifications (if you keep it). Totally feel free to ignore me, though.
| - bundle install | ||
| notifications: | ||
| email: false | ||
| script: rake |
There was a problem hiding this comment.
Would be nice to make this script/cibuild like https://github.com/github/scripts-to-rule-them-all
| @@ -0,0 +1,8 @@ | |||
| sudo: false | |||
| install: | |||
| - bundle install | |||
There was a problem hiding this comment.
Would be nice to make this script/bootstrap or just part of script/cibuild below like https://github.com/github/scripts-to-rule-them-all
|
|
||
| ```bash | ||
| bundle install | ||
| rake |
There was a problem hiding this comment.
Actually: would be nice if this was script/cibuild like https://github.com/github/scripts-to-rule-them-all
|
@cheshire137 Thoughts on adding (in this PR or another) Rubocop checks to keep any modifications to the tests in a consistent style? |
Add, fix Topic Page Style Guide tests
Add testing tweaks
This adds some basic lint tests to ensure each topic has the data we need. Fixes #3.
We could use more tests that will check image file sizes and dimensions, but that may require some extra work to ensure ImageMagick is set up on the CI server. I'd like to wait till we're hooked up with Travis CI before writing such tests.