Add testing tweaks#9
Conversation
|
|
||
| ./script/setup | ||
|
|
||
| set +e |
There was a problem hiding this comment.
Why does this get run again after line 2?
There was a problem hiding this comment.
To allow not failing immediately if rake test fails but also outputting the rubocop failure output (if any)
| metadata = begin | ||
| YAML.load(parts[1]) | ||
| begin | ||
| YAML.safe_load(parts[1]) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Today Rubocop Autocorrected For Me 😜
| lines = File.readlines(path) | ||
|
|
||
| assert lines.size > 0 | ||
| assert !lines.empty? |
There was a problem hiding this comment.
What about refute lines.empty?? Or even refute_predicate lines, :empty? if refute_predicate exists here. 🤔
There was a problem hiding this comment.
👍 to any of them
| refute_empty metadata, "expected some metadata for topic" | ||
|
|
||
| metadata.each do |key, value| | ||
| metadata.each_key do |key,| |
| assert metadata[key]&.strip&.size&.positive?, | ||
| "expected to have a value for '#{key}'" | ||
| end | ||
| end |
There was a problem hiding this comment.
The indentation looks wonky here.
There was a problem hiding this comment.
Yeh, I may have added an extra end here.
|
@cheshire137 Addressed your feedback, thanks! |
|
Aww, script/cibuild wants me to upgrade my ImageMagick! It fails for me, I'll try running the steps it suggests to fix it: |
|
|
Based on my comments on #4 and #5