Add, fix Topic Page Style Guide tests#10
Merged
Conversation
cheshire137
approved these changes
Oct 3, 2017
| end | ||
| end | ||
|
|
||
| def text_for(topic) |
Member
There was a problem hiding this comment.
I might call this body_for. 🤔
| "expected to have a value for '#{key}'" | ||
| end | ||
|
|
||
| it "follows the Topic Page Style Guide" do |
Member
There was a problem hiding this comment.
Thanks for keeping us honest, Mike. 😅
| refute_includes line, "git#{punctuation}", | ||
| 'Always use correct capitalization when referring to "Git"' | ||
|
|
||
| (1..10).each do |digit| |
Member
There was a problem hiding this comment.
I think this should be ... to exclude 10, if we want numbers less than 10.
|
|
||
| %w[and or].each do |conjunction| | ||
| next unless sentence.include? " #{conjunction} " | ||
| assert_includes sentence, ", #{conjunction}", "Always use the Oxford comma" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out we were breaking our own rules 😮.
These are pretty far from perfect but without going down the full NLP rabbit hole they should be better than nothing (as demonstrated by them catching non-nothing).
Fixes #7