Add lint tests for topic images#5
Conversation
| run the tests using: | ||
| There are some lint tests in place to ensure each topic is formatted in the way we expect. Travis | ||
| CI will run the tests automatically. If you want to run the tests yourself locally, you will need | ||
| Ruby, Bundler, and ImageMagick installed. |
There was a problem hiding this comment.
Suggestion: add a Brewfile for imagemagick and follow the https://github.com/github/scripts-to-rule-them-all pattern to allow running tests with a single command.
|
@MikeMcQuaid we may need to go back to ImageMagick 6. I'm hitting an error bundling in this branch now with your brew changes merged in. See https://stackoverflow.com/a/41747901/38743.
|
|
Is there a way to specify a version of imagemagick in Brewfile? The following let the rmagick gem install for me: brew upgrade imagemagick@6
brew link --overwrite --force imagemagick@6
gem install rmagick -v '2.16.0' |
You could use |
|
That said, it may be worth trying to use an alternative to |
|
https://github.com/sdsykes/fastimage looks like it could avoid the imagemagick dependency and get you the information you need. |
What? Nooooooo! I didn't realize. 😢 |
|
The switch to FastImage worked great! Thanks Mike. |
|
@cheshire137 My pleasure. |
|
Ah, I think I need to update the README now to not mention ImageMagick. |
This builds on #4 to address #3 by ensuring topic images are the expected width, height, and file size. I kept this a separate branch from
add-testingin case it requires some fiddling on Travis CI to get ImageMagick set up.