DTP#9320
Merged
Merged
Conversation
Visible animation list now sources data from animationListModule. Can add animations by picking from gallery or uploading. Selecting an animation loads it in Piskel, sourced from animationListModule.
Also sourced from animationListModule now
Set Piskel's framerate option when loading a spritesheet, and save Piskel's framerate option to the animation metadata on a save event. Required adding an onComplete callback to PiskelApi.loadSpritesheet, because the save that happened mid-load was setting the incorrect framerate in the metadata. Remaining problem: Changing the framerate in Piskel does not trigger a save event, so the external preview does not immediately update.
More manual control of when we select a new animation (which triggers the load to Piskel)
And refactors BeeItemDrawer and DirtDrawer to extend it. Previously, BeeItemDrawer inherited from DirtDrawer, although DirtDrawer contained a lot of functionality that BeeItemDrawer intentionally discarded. This refactor plus ES6 class implementation makes their shared vs individual functionality a bit cleaner, and will also make it easier to add a new Drawer for the new WIP Collector Level type.
Instead of giving animation uploads their own interval, hooks the animation save into the regular project save system. Now getting animation metadata to save with the project is an async operation that is always preceded by making sure the animations are saved to S3.
This forces them to be saved with the project. We'll undo this change soonish to keep them by reference, which is more optimal, but for now to get things running this works nicely.
…-load Gamelab: Wait for animation load
Only smooth-scroll the anchor links in the jumbo banner, not all links on page.
Switched order of attachments and mail commands
update blockly i18n
e6f7d1f Merge pull request #9309 from code-dot-org/gamelab-wait-for-animation-load (Brad Buchanan) f5ba7b9 Clarify return value of onP5Preload [ci skip] (Brad Buchanan) 61624ef Comment about self-destructing callback [ci skip] (Brad Buchanan) a8256ab Preload is _always_ async (Brad Buchanan) 0e42aae Improve readability (Brad Buchanan) 9d226da Move completePreload method closer to runPreload method (Brad Buchanan) 7425c7a Wait for animations to load before running game (Brad Buchanan)
Fix links on code.org/educate/applab.
Removed home_dir from deployment.rb.
add banner image to csp3
Level builder changes
teacher announcement for embedding app lab projects
…-class Creates a generic Maze Drawer class
Display firebase data in data browser. make properties view look like the mocks.
Split Blockly#blockly_options into blockly_app_options and blockly_level_options
Sometimes a new empty object is passed in, and `{} !== {}`. Use JSON.stringify to see if anything really changed.
Don't autosave if currentSources.animations is a new object
@islemaster does this sound right?
Update SETUP.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All UI tests green. Eyes tests green after updating one ignore region for bee's wings.