Skip to content

Don't autosave if currentSources.animations is a new object#9316

Merged
joshlory merged 1 commit into
stagingfrom
fix-autosave
Jul 5, 2016
Merged

Don't autosave if currentSources.animations is a new object#9316
joshlory merged 1 commit into
stagingfrom
fix-autosave

Conversation

@joshlory

@joshlory joshlory commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

Sometimes a new empty object is passed in, and {} !== {}. Use JSON.stringify to see if anything really changed.

Don't autosave if currentSources.animations is a new object
18678ab 
Sometimes a new empty object is passed in, and `{} !== {}`. Use JSON.stringify to see if anything really changed.
@joshlory

joshlory commented Jul 5, 2016

Copy link
Copy Markdown
Contributor Author

Verified this fixes the UI test locally:

./runner.rb -d localhost-studio.code.org:3000 -p localhost.code.org:3000 --html -c ChromeLatestWin7 -f features/bigGameVersions.feature 
Test Logger: Starting 1 <b>dashboard</b> UI tests in 1 threads...
Starting UI tests for ChromeLatestWin7_bigGameVersions
cucumber features/bigGameVersions.feature -t ~@eyes -t ~@eyes_mobile -t ~@local_only -t ~@skip -t ~@webpurify -S --format html --out ChromeLatestWin7_bigGameVersions_output.html -f pretty
The key is staging/ChromeLatestWin7_bigGameVersions_output.html
UI tests for ChromeLatestWin7_bigGameVersions succeeded (5:03 minutes, 1 passed)
Test Logger: 1 succeeded.  0 failed. Test count: 1. Total duration: 5:04 minutes. Total reruns of flaky tests: 0.

@islemaster

islemaster commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

LGTM&B

@joshlory joshlory merged commit 9ffabb5 into staging Jul 5, 2016
@joshlory joshlory deleted the fix-autosave branch July 5, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@islemaster islemaster

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshlory @islemaster