Display firebase data in data browser. make properties view look like the mocks.#9281
Merged
Conversation
Member
Author
|
@Bjvanminnen please take a look. no rush on this, as I most likely won't be responding to feedback before Tuesday. |
| getKeyValueData() { | ||
| return Object.keys(this.props.keyValueData).map(key => { | ||
| return [key, this.props.keyValueData[key]]; | ||
| }); |
Contributor
There was a problem hiding this comment.
could make this even a little simpler as follows (up to you):
return Object.keys(this.props.keyValueData).map(key => [key, this.props.keyValueData[key]]);
or if you still want the extra line
return Object.keys(this.props.keyValueData).map(key => (
[key, this.props.keyValueData[key]]
));
Member
Author
There was a problem hiding this comment.
This comment made me realize that getKeyValueData() is useless. I've taken what you suggested here and inlined it in render.
Contributor
|
couple small comments, and looks like a legit test failure, but otherwise lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is some semi complicated stuff going on here which maybe I should add in the comments regarding how and when we listen for data to update the various Data views:
That said, I'm, going to have to change the way we listen to data soon to deal with a few issues, so maybe the comments don't need to be fleshed out until I finish doing that. TODO list:
off()in a way that it only cancels the data browser's listener, preserving any listening done by a call toonRecordEventin the running programspec: https://docs.google.com/document/d/1UfBgHCisr_8jSt8zHFgJL-XrlLthTrXJQZJwoedGYg4/edit#heading=h.4ikfybcr5h8z
properties view:
live update:
