Skip to content

DTT#9312

Merged
joshlory merged 93 commits into
testfrom
staging
Jul 5, 2016
Merged

DTT#9312
joshlory merged 93 commits into
testfrom
staging

Conversation

@joshlory

@joshlory joshlory commented Jul 5, 2016

Copy link
Copy Markdown
Contributor

No description provided.

islemaster and others added 30 commits June 17, 2016 11:02
Visible animation list now sources data from animationListModule.
Can add animations by picking from gallery or uploading.
Selecting an animation loads it in Piskel, sourced from animationListModule.
Also sourced from animationListModule now
Set Piskel's framerate option when loading a spritesheet, and save Piskel's framerate option to the animation metadata on a save event.

Required adding an onComplete callback to PiskelApi.loadSpritesheet, because the save that happened mid-load was setting the incorrect framerate in the metadata.

Remaining problem: Changing the framerate in Piskel does not trigger a save event, so the external preview does not immediately update.
More manual control of when we select a new animation (which triggers the load to Piskel)
Instead of giving animation uploads their own interval, hooks the animation save into the regular project save system.  Now getting animation metadata to save with the project is an async operation that is always preceded by making sure the animations are saved to S3.
This forces them to be saved with the project.  We'll undo this change soonish to keep them by reference, which is more optimal, but for now to get things running this works nicely.
Don't attempt to load an image into Piskel if it's not ready.  When Piskel becomes ready, if an animation is selected, load it.
islemaster and others added 29 commits July 1, 2016 12:16
Allow local override of dashboard test db user
Added unique index for pd_enrollments.code
allow popup video player for inspire videos
…n shouldn't rely on /Users/andrew as this can cause problems in some circumstances, like in a service
Enable "Draw Your Own" option on Animation Tab
Switch to using promises to track completion of preload work.
Rename onPreloadComplete_ to the more precise reportPreloadEventHandlerComplete_
Add function comments that explain this crazy preload process better.
Only smooth-scroll the anchor links in the jumbo banner, not all links on page.
Switched order of attachments and mail commands
e6f7d1f Merge pull request #9309 from code-dot-org/gamelab-wait-for-animation-load (Brad Buchanan)
f5ba7b9 Clarify return value of onP5Preload [ci skip] (Brad Buchanan)
61624ef Comment about self-destructing callback [ci skip] (Brad Buchanan)
a8256ab Preload is _always_ async (Brad Buchanan)
0e42aae Improve readability (Brad Buchanan)
9d226da Move completePreload method closer to runPreload method (Brad Buchanan)
7425c7a Wait for animations to load before running game (Brad Buchanan)
@joshlory joshlory merged commit a351418 into test Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants