move allthethings unit to be owned by original-allthethings-course#66458
Merged
Conversation
5f1c18b to
273a8e3
Compare
7d35df6 to
efb58a7
Compare
556d229 to
3050cc1
Compare
davidsbailey
commented
Jul 23, 2025
| Given I am assigned to course "allthethingscourse" unit 1 | ||
|
|
||
| When I sign in as "Teacher_Sally" and go home | ||
| And I assign my section in row 1 to course "allthethingscourse" unit 1 |
Member
Author
There was a problem hiding this comment.
this change was needed to make sure Sally is assigned to the course as part of Teacher_Sally's section.
daynew
reviewed
Jul 23, 2025
daynew
left a comment
Member
There was a problem hiding this comment.
I went through each commit and commented on things. If a comment is not relevant anymore, please dismiss it.
Co-authored-by: Dayne <dayne@code.org>
daynew
approved these changes
Jul 24, 2025
daynew
left a comment
Member
There was a problem hiding this comment.
Thanks for looking into the potential for using the public APIs and explaining your reasoning for not using them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues https://codedotorg.atlassian.net/browse/TEACH-1970.
Depends on:
Done in this PR:
original-allthethings-courseas the original course for theallthethingsunit, turningallthethingscourseinto a modular course./s/allthethings/...references to/courses/allthethingscourse/units/1/...in UI testsresolved issues:
new progress view -- element
#ui-test-courses-allthethingscourse-units-1-lessons-2-levels-1-cell-datashould use current not original course name: https://cucumber-logs.s3.amazonaws.com/circle/33673/Chrome_teacher_tools_teacher_dashboard_teacher_dashboard_progress_v2_output.html?versionId=R9HhDG7lc0FvXYgWUQfXL7v_AIx_0avJsubmitting bubble choice sublevel goes to original course (intermittent) Chrome_teacher_tools_level_types_bubble_choice_output.html
Testing story